feat: task aging #35
Draft
feat: task aging #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying ephe with
|
| Latest commit: |
3775f70
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://24b89593.ephe.pages.dev |
| Branch Preview URL: | https://task-color.ephe.pages.dev |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Introduces a "task aging" feature that visually fades incomplete tasks over time and lets users toggle it via UI and commands.
- Added a persistent atom and hook to manage task-aging state in localStorage.
- Integrated new menu items and command-palette entries to enable/disable aging.
- Implemented a CodeMirror plugin and extended task storage API to track creation times and compute opacity.
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/hooks/use-task-aging.ts | New hook and atom for persisting task-aging state |
| src/utils/constants.ts | Added LOCAL_STORAGE_KEYS for aging settings and times |
| src/features/menu/system-menu.tsx | Added a system-menu toggle for task aging |
| src/features/menu/command-menu.tsx | Command-palette entry and toast for toggling aging |
| src/features/history/use-history-data.ts | Switched from getAll to getCompletedTasks |
| src/features/editor/tasks/task-storage.ts | Expanded storage API: addTask, toggleTask, date groups |
| src/features/editor/codemirror/use-toc.ts | Updated inline comments to English |
| src/features/editor/codemirror/use-markdown-editor.ts | Hooked in taskAgingPlugin to the markdown editor |
| src/features/editor/codemirror/url-click.ts | Converted some imports to type-only |
| src/features/editor/codemirror/tasklist/task-aging.ts | New ViewPlugin implementing fading logic |
| src/features/editor/codemirror/tasklist/task-aging.test.ts | Basic smoke tests for the aging plugin |
| src/features/editor/codemirror/tasklist/index.ts | Exported aging plugin & updated default task handler |
| package.json | Bumped @biomejs/biome dev dependency |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)
src/features/editor/codemirror/tasklist/task-aging.test.ts:1
- Current tests cover plugin instantiation and basic registration but not opacity calculations or cleanup logic. Add tests for
calculateTaskOpacitythresholds andcleanupOldTasksbehavior to improve coverage.
import { describe, it, expect } from "vitest";
src/utils/hooks/use-task-aging.ts:7
- [nitpick] The hook returns
taskAgingMode, but renaming it totaskAgingEnabledcould improve clarity and align with thetaskAgingEnabledAtomnaming.
export const useTaskAging = () => {
| }; | ||
|
|
||
| const getByDate = (filter?: DateFilter): Record<string, CompletedTask[]> => { | ||
| const getByDate = (filter?: DateFilter): Record<string, Task[]> => { |
There was a problem hiding this comment.
The function casts items with string timestamps back to Task[], but Task.completedAt and Task.createdAt expect numbers. Consider defining a separate return type for date‐grouped items or convert ISO strings back to numbers to keep types accurate.
| }; | ||
|
|
||
| // Calculate task opacity based on age | ||
| const calculateTaskOpacity = (createdAt: number): number => { |
There was a problem hiding this comment.
[nitpick] Hardcoded durations (10s, 20s, 40s) and opacities are currently used for testing. Extract these thresholds into named constants or configuration to improve clarity and allow customization.
Owner
Author
|
@claude review this? |
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27