Skip to content

improved-Footer #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nitanagdeote wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improved-Footer #1356

nitanagdeote wants to merge 1 commit into from

Conversation

@nitanagdeote
Copy link
Collaborator

@nitanagdeote nitanagdeote commented Jul 17, 2025

image

curran
curran requested changes Jul 17, 2025
View reviewed changes
Copy link
Collaborator

@curran curran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:

image

After:

image

Pros:

  • I like the social icons, that's a nice addition
  • There's a huge CTA for "VizBot", which does not exist yet, so just based on that, this PR is not ready to merge
  • There are new broken links to "terms", "privacy" and "cookies" - 3 more reasons this can't be merged as-is
  • There are those odd-looking partial underlines that IMO don't really look that great
  • Half the newly added links don't go to anywhere

Can you do another one with just the changes on the left? I like those:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curran curran curran requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nitanagdeote @curran