fix(dialog): fixed launch settings countdown dialog not being translated

Author: vladelaina

resource/startup_dialog.rc

@@ -14,8 +14,8 @@ CAPTION "Startup Settings - Countdown"
 FONT 9, "Segoe UI"
 BEGIN
     /** Instructional text referencing countdown format compatibility */
-    LTEXT           "Set default countdown time at startup\nFormat is the same as countdown time settings", CLOCK_IDC_STATIC, 10, 10, 180, 30
+    LTEXT           "25=25 minutes\n25h=25 hours\n25s=25 seconds\n25 30=25 minutes 30 seconds\n25 30m=25 hours 30 minutes\n1 30 20=1 hour 30 minutes 20 seconds\n17 20t=Countdown to 17:20\n9 9 9t=Countdown to 9:09:09", CLOCK_IDC_STATIC, 10, 10, 180, 70
     /** Time input using same parser as main countdown dialog */
-    EDITTEXT        CLOCK_IDC_EDIT, 10, 55, 180, 20, ES_AUTOHSCROLL | ES_MULTILINE
-    PUSHBUTTON      "OK", CLOCK_IDC_BUTTON_OK, 140, 105, 50, 14
+    EDITTEXT        CLOCK_IDC_EDIT, 10, 85, 180, 20, ES_AUTOHSCROLL | ES_MULTILINE
+    PUSHBUTTON      "OK", CLOCK_IDC_BUTTON_OK, 140, 108, 50, 14
 END 

src/dialog/dialog_language.c

@@ -51,6 +51,7 @@ static DialogTitleEntry g_dialogTitles[] = {
     {CLOCK_IDD_SHORTCUT_DIALOG, L"Countdown Presets"},
     {CLOCK_IDD_WEBSITE_DIALOG, L"Open Website"},
     {CLOCK_IDD_DIALOG1, L"Set Countdown"},
+    {CLOCK_IDD_STARTUP_DIALOG, L"Startup Settings"},
     {IDD_NO_UPDATE_DIALOG, L"Update Check"},
     {IDD_UPDATE_DIALOG, L"Update Available"}
 };
@@ -119,6 +120,7 @@ static SpecialControlEntry g_specialButtons[] = {
     {CLOCK_IDD_POMODORO_TIME_DIALOG, CLOCK_IDC_BUTTON_OK, L"OK", L"OK"},
     {CLOCK_IDD_WEBSITE_DIALOG, CLOCK_IDC_BUTTON_OK, L"OK", L"OK"},
     {CLOCK_IDD_SHORTCUT_DIALOG, CLOCK_IDC_BUTTON_OK, L"OK", L"OK"},
+    {CLOCK_IDD_STARTUP_DIALOG, CLOCK_IDC_BUTTON_OK, L"OK", L"OK"},
     {CLOCK_IDD_DIALOG1, CLOCK_IDC_BUTTON_OK, L"OK", L"OK"}
 };
 
@@ -141,6 +143,7 @@ static BOOL NeedsNewlineConversion(int dialogID, int controlID) {
             dialogID == CLOCK_IDD_POMODORO_TIME_DIALOG ||
             dialogID == CLOCK_IDD_WEBSITE_DIALOG ||
             dialogID == CLOCK_IDD_SHORTCUT_DIALOG ||
+            dialogID == CLOCK_IDD_STARTUP_DIALOG ||
             dialogID == CLOCK_IDD_DIALOG1) &&
            controlID == CLOCK_IDC_STATIC;
 }
@@ -184,8 +187,12 @@ static BOOL IsLocalizableControlType(const wchar_t* className) {
 }
 
 static const wchar_t* FindSpecialControlText(int dialogID, int controlID) {
+    /* Startup dialog reuses countdown dialog's static text */
+    int searchID = (dialogID == CLOCK_IDD_STARTUP_DIALOG && controlID == CLOCK_IDC_STATIC)
+                   ? CLOCK_IDD_DIALOG1 : dialogID;
+
     for (size_t i = 0; i < ARRAY_SIZE(g_specialControls); i++) {
-        if (g_specialControls[i].dialogID == dialogID &&
+        if (g_specialControls[i].dialogID == searchID &&
             g_specialControls[i].controlID == controlID) {
             const wchar_t* localizedText = GetLocalizedString(NULL, g_specialControls[i].textKey);
             return localizedText ? localizedText : g_specialControls[i].fallbackText;