refactor(config): Use data description instead of code duplication to change the configuration system from manual maintenance to automated processing. At the same time, it customizes the reading of ini and abandons the dependence on windows ini api

Author: vladelaina

include/config.h

@@ -508,27 +508,12 @@ void WriteConfigPomodoroTimeOptions(int* times, int count);
  * Notification configuration functions
  * ============================================================================ */
 
-/**
- * @brief Read notification message texts (with fallbacks)
- */
-void ReadNotificationMessagesConfig(void);
-
 /**
  * @brief Write notification timeout
  * @param timeout_ms Duration (recommended: 3000-10000)
  */
 void WriteConfigNotificationTimeout(int timeout_ms);
 
-/**
- * @brief Read notification timeout (default: 5000ms)
- */
-void ReadNotificationTimeoutConfig(void);
-
-/**
- * @brief Read notification opacity (default: 100, range: 0-100)
- */
-void ReadNotificationOpacityConfig(void);
-
 /**
  * @brief Write notification opacity (auto-clamped to 1-100)
  * @param opacity Opacity (100 = fully opaque)
@@ -541,22 +526,12 @@ void WriteConfigNotificationOpacity(int opacity);
  */
 void WriteConfigNotificationMessages(const char* timeout_msg);
 
-/**
- * @brief Read notification type (default: CATIME)
- */
-void ReadNotificationTypeConfig(void);
-
 /**
  * @brief Write notification type (enum to string)
  * @param type Notification type
  */
 void WriteConfigNotificationType(NotificationType type);
 
-/**
- * @brief Read notification disabled flag (default: FALSE)
- */
-void ReadNotificationDisabledConfig(void);
-
 /**
  * @brief Write notification disabled setting
  * @param disabled TRUE to suppress all notifications
@@ -576,36 +551,18 @@ void WriteConfigLanguage(int language);
  */
 void GetAudioFolderPath(char* path, size_t size);
 
-/**
- * @brief Read notification sound path
- * 
- * @details
- * Supports absolute/relative paths, "SYSTEM_BEEP", or empty (no sound).
- */
-void ReadNotificationSoundConfig(void);
-
 /**
  * @brief Write notification sound path (no validation)
  * @param sound_file Path, "SYSTEM_BEEP", or empty (UTF-8)
  */
 void WriteConfigNotificationSound(const char* sound_file);
 
-/**
- * @brief Read notification volume (default: 50, range: 0-100)
- */
-void ReadNotificationVolumeConfig(void);
-
 /**
  * @brief Write notification volume (auto-clamped to 0-100)
  * @param volume Volume (0=mute, 100=max)
  */
 void WriteConfigNotificationVolume(int volume);
 
-/**
- * @brief Read notification window position and size
- */
-void ReadNotificationWindowConfig(void);
-
 /**
  * @brief Write notification window position and size
  * @param x X position (-1 for auto)

include/config/config_defaults.h

@@ -49,18 +49,30 @@ typedef enum {
     CONFIG_TYPE_STRING,
     CONFIG_TYPE_INT,
     CONFIG_TYPE_BOOL,
-    CONFIG_TYPE_ENUM
+    CONFIG_TYPE_FLOAT,
+    CONFIG_TYPE_ENUM,
+    CONFIG_TYPE_HOTKEY,
+    CONFIG_TYPE_CUSTOM       /* Requires special handling (arrays, wchar_t, etc.) */
 } ConfigValueType;
 
 /* ============================================================================
  * Configuration metadata structure
  * ============================================================================ */
 
+/**
+ * @brief Metadata for a single configuration item
+ * 
+ * @details
+ * When offset is SIZE_MAX, the item requires custom handling.
+ * Otherwise, offset points to the field in ConfigSnapshot.
+ */
 typedef struct {
     const char* section;
     const char* key;
     const char* defaultValue;
     ConfigValueType type;
+    size_t offset;           /* offsetof(ConfigSnapshot, field), SIZE_MAX for custom */
+    size_t size;             /* sizeof(field) for strings, 0 for fixed-size types */
     const char* description;
 } ConfigItemMeta;
 

include/config/config_loader.h

@@ -103,6 +103,7 @@ typedef struct {
     WORD hotkeyPauseResume;
     WORD hotkeyRestartTimer;
     WORD hotkeyCustomCountdown;
+    WORD hotkeyToggleMilliseconds;
 
     /* Recent files */
     RecentFile recentFiles[MAX_RECENT_FILES];

include/config/config_store.h

@@ -0,0 +1,135 @@
+/**
+ * @file config_store.h
+ * @brief Unified configuration store
+ *
+ * Single source of truth for all configuration.
+ * Memory-first design with lazy disk I/O.
+ */
+
+#ifndef CONFIG_STORE_H
+#define CONFIG_STORE_H
+
+#include <windows.h>
+#include "config_keys.h"
+
+/* ============================================================================
+ * Configuration access API
+ * ============================================================================ */
+
+/**
+ * @brief Initialize configuration system
+ * @param config_path Path to config file (UTF-8)
+ *
+ * Loads config from disk if exists, otherwise uses defaults.
+ * Must be called before any other config functions.
+ */
+void Config_Init(const char* config_path);
+
+/**
+ * @brief Shutdown configuration system
+ *
+ * Flushes any pending changes to disk and frees resources.
+ */
+void Config_Shutdown(void);
+
+/**
+ * @brief Get string value
+ * @param key Configuration key
+ * @return String value (do not free, valid until next Set or Shutdown)
+ */
+const char* Config_GetString(ConfigKey key);
+
+/**
+ * @brief Get integer value
+ * @param key Configuration key
+ * @return Integer value
+ */
+int Config_GetInt(ConfigKey key);
+
+/**
+ * @brief Get boolean value
+ * @param key Configuration key
+ * @return Boolean value
+ */
+BOOL Config_GetBool(ConfigKey key);
+
+/**
+ * @brief Get float value
+ * @param key Configuration key
+ * @return Float value
+ */
+float Config_GetFloat(ConfigKey key);
+
+/**
+ * @brief Set string value
+ * @param key Configuration key
+ * @param value New value (will be copied)
+ */
+void Config_SetString(ConfigKey key, const char* value);
+
+/**
+ * @brief Set integer value
+ * @param key Configuration key
+ * @param value New value
+ */
+void Config_SetInt(ConfigKey key, int value);
+
+/**
+ * @brief Set boolean value
+ * @param key Configuration key
+ * @param value New value
+ */
+void Config_SetBool(ConfigKey key, BOOL value);
+
+/**
+ * @brief Set float value
+ * @param key Configuration key
+ * @param value New value
+ */
+void Config_SetFloat(ConfigKey key, float value);
+
+/**
+ * @brief Flush pending changes to disk
+ *
+ * Normally changes are batched. Call this to force immediate write.
+ */
+void Config_Flush(void);
+
+/**
+ * @brief Reload configuration from disk
+ *
+ * Discards any unsaved changes and reloads from file.
+ */
+void Config_Reload(void);
+
+/**
+ * @brief Mark config as dirty (needs save)
+ *
+ * Called automatically by Set functions.
+ */
+void Config_MarkDirty(void);
+
+/**
+ * @brief Check if config has unsaved changes
+ * @return TRUE if dirty
+ */
+BOOL Config_IsDirty(void);
+
+/**
+ * @brief Get config file path
+ * @return Path string (do not free)
+ */
+const char* Config_GetPath(void);
+
+/**
+ * @brief Reset a key to its default value
+ * @param key Configuration key
+ */
+void Config_ResetToDefault(ConfigKey key);
+
+/**
+ * @brief Reset all configuration to defaults
+ */
+void Config_ResetAll(void);
+
+#endif /* CONFIG_STORE_H */

include/dialog/dialog_notification.h

@@ -81,24 +81,17 @@ INT_PTR CALLBACK NotificationSettingsDlgProc(HWND hwndDlg, UINT msg, WPARAM wPar
  * ============================================================================ */
 
 /**
- * @note All notification configuration functions are now declared in config.h
- *       and implemented in config_notification.c:
+ * @note Notification configuration is loaded once at startup via ReadConfig()
+ *       into g_AppConfig. Write functions are in config_notification.c:
  *       
- *       Read functions:
- *       - ReadNotificationMessagesConfig()
- *       - ReadNotificationTimeoutConfig()
- *       - ReadNotificationOpacityConfig()
- *       - ReadNotificationTypeConfig()
- *       - ReadNotificationSoundConfig()
- *       - ReadNotificationVolumeConfig()
- *       
- *       Write functions:
  *       - WriteConfigNotificationMessages(timeout_msg)
  *       - WriteConfigNotificationTimeout(timeout_ms)
  *       - WriteConfigNotificationOpacity(opacity)
  *       - WriteConfigNotificationType(NotificationType type)
  *       - WriteConfigNotificationSound(sound_file)
  *       - WriteConfigNotificationVolume(volume)
+ *       - WriteConfigNotificationWindow(x, y, width, height)
+ *       - WriteConfigNotificationDisabled(disabled)
  */
 
 #endif /* DIALOG_NOTIFICATION_H */

src/config/config_applier.c

@@ -40,14 +40,6 @@ static int LanguageNameToEnum(const char* langName) {
     if (strcmp(langName, "Japanese") == 0) return APP_LANG_JAPANESE;
     if (strcmp(langName, "Korean") == 0) return APP_LANG_KOREAN;
 
-    /* Legacy numeric format support */
-    if (isdigit(langName[0])) {
-        int langValue = atoi(langName);
-        if (langValue >= 0 && langValue < APP_LANG_COUNT) {
-            return langValue;
-        }
-    }
-    
     return APP_LANG_ENGLISH;
 }
 
@@ -244,9 +236,27 @@ void ApplyNotificationSettings(const ConfigSnapshot* snapshot) {
     g_AppConfig.notification.display.window_width = snapshot->notificationWindowWidth;
     g_AppConfig.notification.display.window_height = snapshot->notificationWindowHeight;
 
+    /* Copy sound file path and expand %LOCALAPPDATA% placeholder if needed */
     strncpy(g_AppConfig.notification.sound.sound_file, snapshot->notificationSoundFile, MAX_PATH - 1);
     g_AppConfig.notification.sound.sound_file[MAX_PATH - 1] = '\0';
 
+    /* Normalize %LOCALAPPDATA% placeholder to absolute path */
+    if (g_AppConfig.notification.sound.sound_file[0] != '\0') {
+        const char* varToken = "%LOCALAPPDATA%";
+        size_t tokenLen = strlen(varToken);
+        if (_strnicmp(g_AppConfig.notification.sound.sound_file, varToken, tokenLen) == 0) {
+            const char* localAppData = getenv("LOCALAPPDATA");
+            if (localAppData && localAppData[0] != '\0') {
+                char resolved[MAX_PATH] = {0};
+                snprintf(resolved, sizeof(resolved), "%s%s",
+                         localAppData,
+                         g_AppConfig.notification.sound.sound_file + tokenLen);
+                strncpy(g_AppConfig.notification.sound.sound_file, resolved, MAX_PATH - 1);
+                g_AppConfig.notification.sound.sound_file[MAX_PATH - 1] = '\0';
+            }
+        }
+    }
+    
     g_AppConfig.notification.sound.volume = snapshot->notificationSoundVolume;
 }
 

src/config/config_core.c

@@ -7,8 +7,6 @@
  * - config_loader: Reading and parsing INI files
  * - config_applier: Applying config to global variables
  * - config_writer: Collecting and writing config
- * 
- * This file maintains backward compatibility with the original API.
  */
 #include "config.h"
 #include "config/config_defaults.h"
@@ -144,26 +142,8 @@ void ReadConfig() {
     LOG_INFO("Configuration loading completed successfully");
 }
 
-/**
- * @brief Write complete configuration to file (Coordinator)
- * 
- * @details
- * Delegates to config_writer module.
- */
-/* WriteConfig is now in config_writer module */
-/* Re-exported here for backward compatibility */
-
-/**
- * @brief Create default configuration (Re-exported)
- * 
- * @details
- * Implemented in config_defaults module.
- * Re-exported here for backward compatibility.
- */
-/* CreateDefaultConfig is in config_defaults module */
-
 /* ============================================================================
- * Utility functions kept for backward compatibility
+ * Utility functions
  * ============================================================================ */
 
 /**