Skip to content

Conversation

@windsonsea
Copy link
Contributor

@windsonsea windsonsea commented Nov 12, 2025

Perform a few improvement actions:

  • fix typos and grammars
  • remove redundant spaces from big markdown tables
  • add newline chars to long paras

@mergify
Copy link

mergify bot commented Nov 12, 2025

Documentation preview: https://vllm--28530.org.readthedocs.build/en/28530/

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request does a good job of cleaning up the moe_kernel_features.md document by fixing typos, grammar, and formatting. The changes improve the readability of the document. However, I've noticed a couple of areas in the tables that remain confusing due to duplicated or unclear entries. I've left specific comments with suggestions to address these to further improve the clarity of this important documentation.

Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nice change overall but a couple of general comments:

  • I don't think the commas after e.g./i.e. are necessary
  • The ' after experts are not necessary either. They are kernels for multiple experts, not kernels belonging to multiple experts

@windsonsea windsonsea force-pushed the rlhfli branch 2 times, most recently from fee0d72 to a656c48 Compare November 13, 2025 00:54
@hmellor
Copy link
Member

hmellor commented Nov 13, 2025

For documentation we have been sticking to one line per paragraph because it's easier to maintain when editing the docs.

i.e. it's quite tedious to re-shuffle all the lines if you make an edit that makes one line in a multiline paragraph a bit longer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants