-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
[Docs] Clean up moe_kernel_features.md #28530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Documentation preview: https://vllm--28530.org.readthedocs.build/en/28530/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request does a good job of cleaning up the moe_kernel_features.md document by fixing typos, grammar, and formatting. The changes improve the readability of the document. However, I've noticed a couple of areas in the tables that remain confusing due to duplicated or unclear entries. I've left specific comments with suggestions to address these to further improve the clarity of this important documentation.
hmellor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice change overall but a couple of general comments:
- I don't think the commas after
e.g./i.e.are necessary - The
'afterexpertsare not necessary either. They are kernels for multiple experts, not kernels belonging to multiple experts
fee0d72 to
a656c48
Compare
Signed-off-by: windsonsea <[email protected]>
|
For documentation we have been sticking to one line per paragraph because it's easier to maintain when editing the docs. i.e. it's quite tedious to re-shuffle all the lines if you make an edit that makes one line in a multiline paragraph a bit longer |
Perform a few improvement actions: