Skip to content

Commit 0c46218

Browse files
Apply suggestions from code review
Co-authored-by: Copilot <[email protected]>
1 parent ef22165 commit 0c46218

File tree

1 file changed

+14
-13
lines changed

1 file changed

+14
-13
lines changed

.github/copilot-instructions.md

Lines changed: 14 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ When in doubt, prioritize checking these:
1414
4. **WebIDL** is valid and matches algorithm behavior.
1515
5. **Security, privacy, a11y, and i18n** concerns are not obviously violated.
1616
6. **Commit messages** follow the project’s conventions.
17-
If you can only do a few things on a PR, focus on these.
17+
If you are unable to perform a comprehensive review of a PR, prioritize checking these key areas.
1818
</CoreRules>
1919

2020
---
@@ -76,9 +76,10 @@ Use bar syntax:
7676
</AlgorithmVariables>
7777

7878
<HTMLElementReferences>
79-
Use caret syntax:
79+
Use caret syntax for HTML elements:
8080
- `[^iframe^]`
8181
- `[^input^]`
82+
To reference an attribute of an element, use `[^element/attribute^]`:
8283
- `[^iframe/allow^]`
8384
</HTMLElementReferences>
8485

@@ -111,16 +112,16 @@ Use internal expansion syntax:
111112
<NormativeReferences>
112113
This specification normatively depends on:
113114

114-
- [credential-management] — Credential Management Level 1
115-
- [dom] — DOM Standard
116-
- [html] — HTML Standard
117-
- [infra] — Infra Standard
118-
- [permissions] — Permissions API
119-
- [permissions-policy] — Permissions Policy
120-
- [RFC2119]
121-
- [RFC8174]
122-
- [vc-data-model] — Verifiable Credentials Data Model v2.0
123-
- [WebIDL] — Web IDL Standard
115+
- [[CREDENTIAL-MANAGEMENT]] — Credential Management Level 1
116+
- [[DOM]] — DOM Standard
117+
- [[HTML]] — HTML Standard
118+
- [[INFRA]] — Infra Standard
119+
- [[PERMISSIONS]] — Permissions API
120+
- [[PERMISSIONS-POLICY]] — Permissions Policy
121+
- [[RFC2119]]
122+
- [[RFC8174]]
123+
- [[VC-DATA-MODEL]] — Verifiable Credentials Data Model v2.0
124+
- [[WEBIDL]] — Web IDL Standard
124125

125126
<NormativeChecks>
126127
- When a concept overlaps with these specs, suggest reusing or referencing the existing definition rather than inventing a new one.
@@ -205,7 +206,7 @@ This spec uses RFC 2119 / BCP 14 keywords.
205206

206207
<RFCChecks>
207208
- Check that MUST, MUST NOT, SHOULD, SHOULD NOT, MAY appear only in normative contexts.
208-
- Conformance requirements using RFC2119 keywords only apply to a "user agent" implementing the specification (i.e., "A user agent MUST..." or where the context is obvious). There are no other conformance classes/objects (e.g., "Developers MUST..." would be wrong).
209+
- In this specification, RFC2119 keywords (MUST, SHOULD, MAY, etc.) are only to be used in conformance requirements that apply to the "user agent" implementing the specification (e.g., "A user agent MUST..."). No other conformance classes or objects (such as "Developer") are defined, so using these keywords for other entities is incorrect.
209210
- Flag use of these keywords in notes, examples, or purely explanatory/editorial text.
210211
- Watch for informal uses like “the browser should...” that may be intended as normative but are not clearly framed.
211212
- If the intended strength of a requirement is unclear (MUST vs SHOULD), it’s reasonable to ask for clarification.

0 commit comments

Comments
 (0)