Add and optional 'preprocess merging' step to the closure segmenter. #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation could be slow in fonts with a large number of segments since it is O(total number of segments - segments ids), the fast path is roughly O(segment ids). Also includes optimizations to feature tag subtraction implementation.
garretrieger
force-pushed
the
closure_opt
branch
from
cf8bca3 to
3d75f36
Compare
When enabled this merges adjacent segments below a given probability threshold before any other processing (such as closure analysis) occurs. Can be used to speed up segmenter and merging analysis by premerging low probability segments.
garretrieger
force-pushed
the
closure_opt
branch
from
3d75f36 to
5788617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preprocess merges are performed prior to closure analysis and the regular merging phase. These merges just merge adjacent segments to a configurable group size that are below a configurable probability threshold. Primary use case for this is to pregroup low probability segments that don't need the more complex analysis due to their low impact on overall cost.
Additionally includes some optimizations to the generation of the "except segment" during closure analysis. Adds an alternate implementation that is faster for small input segments.