Implement --die-on

Author: kfranqueiro

generators/bikeshed.ts

@@ -57,12 +57,14 @@ const generateFilename = (url: string) =>
 /**
  * Invokes bikeshed on a URL with the given options.
  * @param input HTTPS URL or file path to process
- * @param options Additional CLI arguments
+ * @param modeOptions Additional CLI arguments specified after the mode
+ * @param globalOptions Additional CLI arguments specified before the mode
  */
 async function invokeBikeshed(
     input: string,
     mode: BikeshedType,
-    options: string[] = [],
+    modeOptions: string[] = [],
+    globalOptions: string[] = [],
 ) {
     if (!bikeshedVersion) {
         throw new SpecGeneratorError(
@@ -81,17 +83,16 @@ async function invokeBikeshed(
             [
                 "--print=json",
                 "--no-update",
+                ...globalOptions,
                 mode,
                 input,
                 outputPath,
-                ...options,
+                ...modeOptions,
             ],
             { timeout: 30000 },
         );
         const pid = bikeshedProcess.pid;
-        console.log(
-            `[bikeshed(${pid})] generating ${mode} ${input}${options.length ? ` (${options})` : ""}`,
-        );
+        console.log(`[bikeshed(${pid})] generating ${mode} ${input}`);
 
         const stdoutChunks: string[] = [];
         bikeshedProcess.stdout.on("data", (data) => stdoutChunks.push(data));
@@ -200,7 +201,12 @@ const generateSpec = async (input: string, params: URLSearchParams) => {
     for (const [key, value] of params.entries()) {
         if (key.startsWith("md-")) metadataOverrides.push(`--${key}=${value}`);
     }
-    return invokeBikeshed(input, "spec", metadataOverrides);
+    return invokeBikeshed(
+        input,
+        "spec",
+        metadataOverrides,
+        params.has("die-on") ? [`--die-on=${params.get("die-on")}`] : [],
+    );
 };
 
 /** Runs `bikeshed issues-list`, fetching from remote server if a URL is specified. */

partials/layout.html

@@ -34,9 +34,7 @@
             input {
                 background: #eee;
                 border: 1px solid #999;
-                line-height: 1.5;
                 padding: 0.2rem;
-                margin-bottom: 0.5em;
             }
 
             fieldset {
@@ -62,6 +60,8 @@
             }
 
             .either input {
+                line-height: 1.5;
+                margin-bottom: 0.5em;
                 width: 100%;
             }
 

views/bikeshed.html

@@ -5,6 +5,15 @@
     body:has(#type-spec:checked) .issues-only {
         display: none;
     }
+
+    fieldset div:not(:first-of-type, :last-of-type) {
+        margin: 1em 0;
+    }
+
+    fieldset div label:first-child {
+        display: inline-block;
+        width: 12em;
+    }
 </style>
 {% endblock %}
 {% block %}
@@ -16,19 +25,28 @@
     <label for="type-{{ item[0] }}">{{ item[1] }}</label>
     {% endfor %}
 </fieldset>
-<fieldset class="spec-only">
-    <legend>Spec options</legend>
+<fieldset>
+    <legend>Options</legend>
     <div>
+        <label for="die-on">Die on</label>
+        <select name="die-on" id="die-on">
+            <option value="nothing">Nothing (force)</option>
+            <option value="fatal" selected>Fatal</option>
+            <option value="link-error">Link error</option>
+            <option value="warning">Warning</option>
+            <option value="lint">Lint</option>
+            <option value="message">Message</option>
+            <option value="everything">Everything</option>
+        </select>
+    </div>
+    <div class="spec-only">
         <label for="date">Date (defaults to <code>now</code>)</label>
         <input name="md-date" id="date">
     </div>
-    <div>
+    <div class="spec-only">
         <input type="checkbox" name="md-prepare-for-tr" value="yes" id="tr">
         <label for="tr">Prepare for TR</label>
     </div>
-    <div>
-
-    </div>
 </fieldset>
 <div class="either">
     <fieldset>