Skip to content

Commit 78b0d74

Browse files
committed
Work around bikeshed 5.3.5 regression
1 parent ec3d14c commit 78b0d74

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ jobs:
1515
with:
1616
node-version: ${{ matrix.node-version }}
1717
- name: Install bikeshed
18-
# NOTE: Pinning to 5.3.4 due to regression #3198 in 5.3.5
19-
run: pipx install bikeshed==5.3.4 && bikeshed update
18+
run: pipx install bikeshed && bikeshed update
2019
- run: npm install
2120
- run: npx respec2html -e --timeout 30 --src "https://w3c.github.io/spec-generator/respec.html"
2221
- run: npm test

generators/bikeshed.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,10 @@ async function invokeBikeshed(
124124

125125
const stdout = stdoutChunks
126126
.join("")
127-
// Correct unfinished JSON in case of fatal error
128-
.replace(/,[\n\s]*$/, "]")
129-
// Correct for speced/bikeshed#3197
127+
// Correct unfinished JSON in case of fatal error,
128+
// which may not include a trailing comma in 5.3.5 (#3198)
129+
.replace(/\},?[\n\s]*$/, "}]")
130+
// Correct for #3197 (fixed in bikeshed 5.3.5)
130131
.replace(/\n\[/g, "");
131132

132133
try {

0 commit comments

Comments
 (0)