Re-run challenge header processing after creating a session #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To relieve site developers from having to understand the nuances of DBSC's fetch integration, we want to allow the registration response to do both registration and set a challenge. This change is needed because normally, the challenge header is processed before registration, and at that point there is no session to cache the requested challenge onto.
thefrog-gh
approved these changes
Sep 30, 2025
github-actions bot
added a commit
that referenced
this pull request
Sep 30, 2025
SHA: ae7c6c9 Reason: push, by drubery Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To relieve site developers from having to understand the nuances of DBSC's fetch integration, we want to allow the registration response to do both registration and set a challenge.
This change is needed because normally, the challenge header is processed before registration, and at that point there is no session to cache the requested challenge onto.