block_builder: promotee tags might have siblings #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eg
```html
<div>
<blockquote></blockquote>
<tag></tag>
<blockquote></blockquote>
</div>
```
Needs to become
```html
<blockquote></blockquote>
<div>
<tag></tag>
</div>
<blockquote></blockquote>
```
Before it became
```html
<blockquote></blockquote>
```
This solves the following crash
ValueError: Cannot replace one element with another when the element to be replaced is not part of a tree.
Related wagtail#141
nickmoreton
added
Investigate further
waiting for after 0.3.1 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg
Needs to become
Before it became
This solves the following crash
ValueError: Cannot replace one element with another when the element to be replaced is not part of a tree.
Related #141
(Description)
Ticket URL: #141
Testing
Documentation.