Test that validation is still enforced on save_revision when saving or scheduling

As per wagtail/rfcs#104 (comment) - unless clean=False is explicitly passed, validation should be applied, including on fields that would accept nulls at the database level.

Author: gasman

wagtail/tests/test_page_model.py

@@ -982,6 +982,20 @@ def test_raises_error_if_non_specific_page_used(self):
             "page.save_revision() must be called on the specific version of the page. Call page.specific.save_revision() instead.",
         )
 
+    def test_validate_on_save_revision(self):
+        christmas_event = EventPage.objects.get(url_path="/home/events/christmas/")
+        christmas_event.date_from = None
+        with self.assertRaises(ValidationError):
+            christmas_event.save_revision()
+
+    def test_validate_on_schedule_revision(self):
+        christmas_event = EventPage.objects.get(url_path="/home/events/christmas/")
+        christmas_event.date_from = None
+        with self.assertRaises(ValidationError):
+            christmas_event.save_revision(
+                approved_go_live_at=timezone.now() + datetime.timedelta(days=1)
+            )
+
 
 class TestLiveRevision(TestCase):
     fixtures = ["test.json"]