Fix doubled-word typos in crates/ comments#9338
Merged
alokedesai merged 4 commits intoApr 29, 2026
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can follow along in the session on Warp. I approved this pull request and requested human review from: @vorporeal, @zachbai, @szgupta. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR fixes duplicated-word typos in comments and doc comments across crates without changing executable code.
Concerns
- Non-blocking nit: one edited wasm logger doc comment still says "which the given config" and should read "with the given config".
- Security pass: no security-relevant code or configuration changes were introduced.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve with nits
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
alokedesai
approved these changes
Apr 28, 2026
Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
Contributor
|
I'm checking this implementation PR for association with a likely matching ready issue. Powered by Oz |
alokedesai
approved these changes
Apr 28, 2026
Member
alokedesai
left a comment
alokedesai
left a comment
There was a problem hiding this comment.
Thanks for contributing! Warp OSS ftw
waynehoover
added a commit
to waynehoover/warp
that referenced
this pull request
Apr 29, 2026
Folds in the three doubled-word fixes from warpdotdev#9338 that the author deferred while warpdotdev#9279 was open: "that that", "the the", "the the".
captainsafia
pushed a commit
that referenced
this pull request
Apr 30, 2026
### Description Follow-up to #9338 (which fixed doubled-word typos under `crates/`). While running a similar pass over `app/src/`, I picked up a handful of common single-word misspellings, all in comments and doc comments — no identifiers, behavior, or test names touched. | Misspelling | Correction | Occurrences | |---|---|---| | `accomodate` | `accommodate` | 2 | | `indvidual` | `individual` | 1 | | `occured` | `occurred` | 2 | | `overwritting` | `overwriting` | 1 | | `recieve` / `recieved` | `receive` / `received` | 3 | | `seperate` / `seperation` / `seperator` | `separate` / `separation` / `separator` | 3 | ### Testing Comments only — nothing to run. `cargo fmt -p app -- --check` and `cargo fmt -p warpui_core -- --check` both pass. ### Server API No server changes. ### Agent Mode Not applicable. ### Changelog Entries None. Co-authored-by: anshul-garg27 <anshul-garg27@users.noreply.github.com>
captainsafia
added
the
external-contributor
Warp Dev Github Integration
zerx-lab
pushed a commit
to zerx-lab/zap
that referenced
this pull request
May 3, 2026
## Description While reading through a few crates I kept noticing duplicated words in comments — "the the", "in in", "to to", "and and", "a a", "that that". A quick `grep` turned up 17 of them across 15 files. All edits are in `//` and `///` comments — no code, test, or behavior change. Files touched: - `crates/settings/src/manager.rs` - `crates/websocket/src/sink_map_err.rs` - `crates/warp_completer/src/completer/suggest/test.rs` - `crates/warp_completer/src/completer/engine/argument/legacy.rs` - `crates/warp_completer/src/completer/engine/argument/v2.rs` - `crates/warp_core/src/ui/color/contrast.rs` - `crates/warp_logging/src/wasm.rs` - `crates/warpui_core/src/core/app.rs` - `crates/warpui_core/src/elements/selectable_area.rs` - `crates/warpui_core/src/elements/flex/mod_test.rs` - `crates/warpui/src/platform/mac/text_layout_test.rs` - `crates/warpui/src/platform/mac/rendering/wgpu/mod.rs` - `crates/warpui/src/platform/app.rs` - `crates/warpui/src/windowing/winit/fonts/font_handle.rs` - `crates/warpui/src/fonts/text_layout_test.rs` Distinct from warpdotdev#9318, which sweeps single-word misspellings (Surpress, occassionally, etc.) under `app/`. I also skipped the two doubled-word lines in `crates/integration/src/test.rs` since warpdotdev#9279 is currently editing that file — happy to fold them in if that PR lands first. ## Testing Comments-only. --------- Co-authored-by: anshul-garg27 <anshul-garg27@users.noreply.github.com> Co-authored-by: Aloke Desai <aloke.desai@gmail.com> Co-authored-by: oz-for-oss[bot] <277970191+oz-for-oss[bot]@users.noreply.github.com>
zerx-lab
pushed a commit
to zerx-lab/zap
that referenced
this pull request
May 3, 2026
### Description Follow-up to warpdotdev#9338 (which fixed doubled-word typos under `crates/`). While running a similar pass over `app/src/`, I picked up a handful of common single-word misspellings, all in comments and doc comments — no identifiers, behavior, or test names touched. | Misspelling | Correction | Occurrences | |---|---|---| | `accomodate` | `accommodate` | 2 | | `indvidual` | `individual` | 1 | | `occured` | `occurred` | 2 | | `overwritting` | `overwriting` | 1 | | `recieve` / `recieved` | `receive` / `received` | 3 | | `seperate` / `seperation` / `seperator` | `separate` / `separation` / `separator` | 3 | ### Testing Comments only — nothing to run. `cargo fmt -p app -- --check` and `cargo fmt -p warpui_core -- --check` both pass. ### Server API No server changes. ### Agent Mode Not applicable. ### Changelog Entries None. Co-authored-by: anshul-garg27 <anshul-garg27@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While reading through a few crates I kept noticing duplicated words in comments — "the the", "in in", "to to", "and and", "a a", "that that". A quick
grepturned up 17 of them across 15 files. All edits are in//and///comments — no code, test, or behavior change.Files touched:
crates/settings/src/manager.rscrates/websocket/src/sink_map_err.rscrates/warp_completer/src/completer/suggest/test.rscrates/warp_completer/src/completer/engine/argument/legacy.rscrates/warp_completer/src/completer/engine/argument/v2.rscrates/warp_core/src/ui/color/contrast.rscrates/warp_logging/src/wasm.rscrates/warpui_core/src/core/app.rscrates/warpui_core/src/elements/selectable_area.rscrates/warpui_core/src/elements/flex/mod_test.rscrates/warpui/src/platform/mac/text_layout_test.rscrates/warpui/src/platform/mac/rendering/wgpu/mod.rscrates/warpui/src/platform/app.rscrates/warpui/src/windowing/winit/fonts/font_handle.rscrates/warpui/src/fonts/text_layout_test.rsDistinct from #9318, which sweeps single-word misspellings (Surpress, occassionally, etc.) under
app/. I also skipped the two doubled-word lines incrates/integration/src/test.rssince #9279 is currently editing that file — happy to fold them in if that PR lands first.Testing
Comments-only.