test(e2e): improve inline enum test case (#6065)

Author: chenjiahan

e2e/cases/optimization/inline-const/index.test.ts

@@ -8,14 +8,14 @@ rspackOnlyTest(
       cwd: __dirname,
       page,
     });
-    await page.waitForFunction(() => window.test3);
-    expect(await page.evaluate(() => window.test1)).toBe('fish,FISH');
-    expect(await page.evaluate(() => window.test2)).toBe('cat,CAT');
-    expect(await page.evaluate(() => window.test3)).toBe('dog,DOG');
+    await page.waitForFunction(() => window.testDog);
+    expect(await page.evaluate(() => window.testFish)).toBe('fish,FISH');
+    expect(await page.evaluate(() => window.testCat)).toBe('cat,CAT');
+    expect(await page.evaluate(() => window.testDog)).toBe('dog,DOG');
 
     const indexJs = await rsbuild.getIndexBundle();
-    expect(indexJs).toContain('window.test1="fish,FISH"');
-    expect(indexJs).toContain('window.test2="cat,CAT"');
+    expect(indexJs).toContain('window.testFish="fish,FISH"');
+    expect(indexJs).toContain('window.testCat="cat,CAT"');
 
     await rsbuild.close();
   },
@@ -28,9 +28,9 @@ test('should import the constants as expected in development mode', async ({
     cwd: __dirname,
     page,
   });
-  await page.waitForFunction(() => window.test3);
-  expect(await page.evaluate(() => window.test1)).toBe('fish,FISH');
-  expect(await page.evaluate(() => window.test2)).toBe('cat,CAT');
-  expect(await page.evaluate(() => window.test3)).toBe('dog,DOG');
+  await page.waitForFunction(() => window.testDog);
+  expect(await page.evaluate(() => window.testFish)).toBe('fish,FISH');
+  expect(await page.evaluate(() => window.testCat)).toBe('cat,CAT');
+  expect(await page.evaluate(() => window.testDog)).toBe('dog,DOG');
   await rsbuild.close();
 });

e2e/cases/optimization/inline-const/src/index.ts

@@ -2,15 +2,15 @@ import { CAT, FISH } from './constants';
 
 declare global {
   interface Window {
-    test1: string;
-    test2: string;
-    test3: string;
+    testFish: string;
+    testCat: string;
+    testDog: string;
   }
 }
 
-window.test1 = `${FISH},${FISH.toUpperCase()}`;
-window.test2 = `${CAT},${CAT.toUpperCase()}`;
+window.testFish = `${FISH},${FISH.toUpperCase()}`;
+window.testCat = `${CAT},${CAT.toUpperCase()}`;
 
 import('./constants2').then(({ DOG }) => {
-  window.test3 = `${DOG},${DOG.toUpperCase()}`;
+  window.testDog = `${DOG},${DOG.toUpperCase()}`;
 });

e2e/cases/typescript/const-enum/index.test.ts

@@ -1,15 +1,42 @@
-import { build } from '@e2e/helper';
+import { build, dev, rspackOnlyTest } from '@e2e/helper';
 import { expect, test } from '@playwright/test';
 
-test('should compile const enum correctly', async ({ page }) => {
-  await build({
+rspackOnlyTest(
+  'should inline the enum values in production mode',
+  async ({ page }) => {
+    const rsbuild = await build({
+      cwd: __dirname,
+      page,
+    });
+
+    await page.waitForFunction(() => window.testDog);
+    expect(await page.evaluate(() => window.testFish)).toBe('fish,FISH');
+    expect(await page.evaluate(() => window.testCat)).toBe('cat,CAT');
+    expect(await page.evaluate(() => window.testDog)).toBe('dog,DOG');
+    expect(await page.evaluate(() => window.testNumbers)).toBe('0,1,1.0');
+
+    const indexJs = await rsbuild.getIndexBundle();
+    expect(indexJs).toContain('window.testFish="fish,FISH"');
+    expect(indexJs).toContain('window.testCat="cat,CAT"');
+    expect(indexJs).toContain('window.testNumbers="0,1,1.0"');
+
+    await rsbuild.close();
+  },
+);
+
+test('should import the enum values as expected in development mode', async ({
+  page,
+}) => {
+  const rsbuild = await dev({
     cwd: __dirname,
     page,
   });
-  expect(await page.evaluate(() => window.test1)).toBe('Fish fish, Cat cat');
-  expect(await page.evaluate(() => window.test2)).toBe('Fish 0, Cat 1');
 
-  // https://github.com/web-infra-dev/rsbuild/issues/5959
-  expect(await page.evaluate(() => window.test3)).toBe('Fish FISH, Cat CAT');
-  expect(await page.evaluate(() => window.test4)).toBe('Fish 0, Cat 1');
+  await page.waitForFunction(() => window.testDog);
+  expect(await page.evaluate(() => window.testFish)).toBe('fish,FISH');
+  expect(await page.evaluate(() => window.testCat)).toBe('cat,CAT');
+  expect(await page.evaluate(() => window.testDog)).toBe('dog,DOG');
+  expect(await page.evaluate(() => window.testNumbers)).toBe('0,1,1.0');
+
+  await rsbuild.close();
 });

e2e/cases/typescript/const-enum/src/foo.ts renamed to e2e/cases/typescript/const-enum/src/constants.ts

@@ -4,7 +4,7 @@ export enum Animals {
 }
 
 // biome-ignore lint/suspicious/noConstEnum: for testing
-export const enum Animals2 {
-  Fish = 0,
-  Cat = 1,
+export const enum Numbers {
+  Zero = 0,
+  One = 1,
 }

e2e/cases/typescript/const-enum/src/constants2.ts

@@ -0,0 +1,4 @@
+// biome-ignore lint/suspicious/noConstEnum: for testing
+export const enum Animals2 {
+  Dog = 'dog',
+}

e2e/cases/typescript/const-enum/src/index.ts

@@ -1,15 +1,18 @@
-import { Animals, Animals2 } from './foo';
+import { Animals, Numbers } from './constants';
 
 declare global {
   interface Window {
-    test1: string;
-    test2: string;
-    test3: string;
-    test4: string;
+    testFish: string;
+    testCat: string;
+    testDog: string;
+    testNumbers: string;
   }
 }
 
-window.test1 = `Fish ${Animals.Fish}, Cat ${Animals.Cat}`;
-window.test2 = `Fish ${Animals2.Fish}, Cat ${Animals2.Cat}`;
-window.test3 = `Fish ${Animals.Fish.toUpperCase()}, Cat ${Animals.Cat.toUpperCase()}`;
-window.test4 = `Fish ${Animals2.Fish.toString()}, Cat ${Animals2.Cat.toString()}`;
+window.testFish = `${Animals.Fish},${Animals.Fish.toUpperCase()}`;
+window.testCat = `${Animals.Cat},${Animals.Cat.toUpperCase()}`;
+window.testNumbers = `${Numbers.Zero},${Numbers.One},${Numbers.One.toFixed(1)}`;
+
+import('./constants2').then(({ Animals2 }) => {
+  window.testDog = `${Animals2.Dog},${Animals2.Dog.toUpperCase()}`;
+});