You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: no hard dependency on nest_asyncio, use only when needed
That change made nest_asyncio optional and only required it when FileInput.readinto() is called from a thread with an event loop.
The current failure suggests that the published 3.0.0a3 artifact does not include #311, or that the 3.0 alpha release line was cut from stale/divergent code.
Why this surfaced now:
On June 9, downstream CI installed ipykernel==7.2.0, which pulled in nest-asyncio==1.6.0.
yank/retract stale 3.0.0a* releases if the 3.0 alpha line is not intended for use; or
otherwise ensure the 3.0 alpha branch contains the same optional nest_asyncio handling as master.
I do not think the correct fix is to add a hard dependency on nest-asyncio, because #311 explicitly changed the design to avoid a hard dependency and only require it when actually needed.
Downstream prerelease CI started failing with
ipyvuetify==3.0.0a3afteripykernel==7.3.0was released.The failure is:
Import chain:
This looks like the old pre-#311 behavior, where
ipyvuetify/extra/file_input.pyimportednest_asynciounconditionally at module import time.However, #311 was merged on Apr 8, 2024:
That change made
nest_asynciooptional and only required it whenFileInput.readinto()is called from a thread with an event loop.The current failure suggests that the published
3.0.0a3artifact does not include #311, or that the 3.0 alpha release line was cut from stale/divergent code.Why this surfaced now:
ipykernel==7.2.0, which pulled innest-asyncio==1.6.0.ipykernel==7.3.0, which switched tonest-asyncio2(see Switch from using nest-asyncio to nest-asyncio2 ipython/ipykernel#1499).nest-asynciowas no longer installed transitively,ipyvuetify==3.0.0a3crashed while importingFileInput.Expected behavior:
Importing
ipyvuetify.extra.FileInputshould not requirenest_asyncio, matching the intent and implementation of #311.Suggested upstream fix:
3.0.0a4that includes fix: no hard dependency on nest_asyncio, use only when needed. #311; or3.0.0a*releases if the 3.0 alpha line is not intended for use; ornest_asynciohandling as master.I do not think the correct fix is to add a hard dependency on
nest-asyncio, because #311 explicitly changed the design to avoid a hard dependency and only require it when actually needed.