Translate AbstractPost to Swift #25040
Merged
+97
−197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30099 | |
| Version | PR #25040 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 83c8cc0 | |
| Installation URL | 60slvav9m6be8 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30099 | |
| Version | PR #25040 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 83c8cc0 | |
| Installation URL | 60uounfbr3u50 |
kean
reviewed
Dec 8, 2025
| } | ||
|
|
||
| @objc | ||
| func hasPhoto() -> Bool { |
Contributor
There was a problem hiding this comment.
Let's move these method in PostEditor+Publish.swift as a private Swift-only extension.
| } | ||
|
|
||
| @objc | ||
| func shouldPublishImmediately() -> Bool { |
Contributor
There was a problem hiding this comment.
shouldPublishImmediately and some of the other methods are not used from Objective-C.
| /// Returns YES if the post is a published. | ||
| @objc | ||
| func isPublished() -> Bool { | ||
| status == .publish |
Contributor
There was a problem hiding this comment.
This method is used in a single place. Let's remove it and review other similar methods that are one-liners and don't create much value.
Contributor
Author
|
@kean I have addressed your feedbacks in the commits above. |
|
| if url.isFileURL { | ||
| requestURL = url | ||
| } else if post.isPrivateAtWPCom() && url.isHostedAtWPCom { | ||
| } else if post.blog.isPrivateAtWPCom() && url.isHostedAtWPCom { |
Contributor
There was a problem hiding this comment.
Nice, I like the removal of these excessive convenience methods that proxy to blog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR translates the majority of the AbstractPost functions to Swift. It should be pretty straightforward to review commit by commit.