Various fixes [release]

Author: crschnick

app/src/main/java/io/xpipe/app/comp/base/ContextualFileReferenceSync.java

@@ -67,6 +67,7 @@ public boolean handle(ErrorEvent event) {
                                             return true;
                                         }
                                     });
+                            event.expected();
                             event.handle();
 
                             if (rename.get()) {

app/src/main/java/io/xpipe/app/prefs/ExternalApplicationType.java

@@ -13,6 +13,7 @@
 
 import java.io.IOException;
 import java.nio.file.Files;
+import java.nio.file.InvalidPathException;
 import java.nio.file.Path;
 import java.util.Optional;
 
@@ -160,7 +161,14 @@ default Optional<Path> determineFromPath() {
                 String name = getExecutable();
                 var out = sc.view().findProgram(name);
                 if (out.isPresent()) {
-                    return out.map(filePath -> Path.of(filePath.toString()));
+                    return out.flatMap(filePath -> {
+                        try {
+                            return Optional.of(Path.of(filePath.toString()));
+                        } catch (InvalidPathException ex) {
+                            ErrorEventFactory.fromThrowable(ex).omit().handle();
+                            return Optional.empty();
+                        }
+                    });
                 }
             } catch (Exception ex) {
                 ErrorEventFactory.fromThrowable(ex).omit().handle();

dist/changelog/19.4_incremental.md

@@ -1,3 +1,7 @@
-- Fix URLs not opening in current Debian sid
-- Improve handling of connection filter
+- Fix URLs not opening in browser on current Debian sid and potentially other Linux systems
+- Fix file browser defaulting to SFTP for connections with no saved state, e.g. when they were synced the first time via git
+- Fix password field sometimes throwing errors when capslock was active
+- Fix connection filter string match count sometimes being wrong
+- Fix connection filter always switching category even if it was not necessary
+- Fix errors in SFTP session when right-clicking certain files
 - Improve Korean translations (Thanks to @nillpoe)

ext/base/src/main/java/io/xpipe/ext/base/host/HostAddressChoiceComp.java

@@ -64,13 +64,9 @@ public CompStructure<HBox> createBase() {
             nodes.add(addButton);
         }
 
-        var layout = new InputGroupComp(nodes).apply(struc -> struc.get().setFillHeight(true));
-        layout.apply(struc -> {
-            struc.get().focusedProperty().addListener((observable, oldValue, newValue) -> {
-                struc.get().getChildren().getFirst().requestFocus();
-            });
-        });
-
+        var layout = new InputGroupComp(nodes);
+        layout.setMainReference(combo);
+        layout.apply(struc -> struc.get().setFillHeight(true));
         return new SimpleCompStructure<>(layout.createStructure().get());
     }
 

ext/base/src/main/java/io/xpipe/ext/base/service/ServiceProtocolTypeHelper.java

@@ -37,7 +37,9 @@ private static OptionsBuilder http(Property<ServiceProtocolType.Http> p) {
         var path = new SimpleStringProperty(p.getValue() != null ? p.getValue().getPath() : null);
         return new OptionsBuilder()
                 .nameAndDescription("servicePath")
-                .addString(path)
+                .addComp(new TextFieldComp(path).apply(struc -> {
+                    struc.get().setPromptText("/sub/path");
+                }), path)
                 .bind(
                         () -> {
                             return new ServiceProtocolType.Http(path.get());
@@ -49,7 +51,9 @@ private static OptionsBuilder https(Property<ServiceProtocolType.Https> p) {
         var path = new SimpleStringProperty(p.getValue() != null ? p.getValue().getPath() : null);
         return new OptionsBuilder()
                 .nameAndDescription("servicePath")
-                .addString(path)
+                .addComp(new TextFieldComp(path).apply(struc -> {
+                    struc.get().setPromptText("/sub/path");
+                }), path)
                 .bind(
                         () -> {
                             return new ServiceProtocolType.Https(path.get());

version

@@ -1 +1 @@
-19.4-1
+19.4