Setting mesh scalars from array

[ivmartel]

Hi,
When setting the mesh scalars from an array (as suggested on L15 of lesson 12), it seems its min/max are not recalculated. I'm doing it this way:

mesh.scalars.array = xScalars;
mesh.scalars.lowerThreshold = min;
mesh.scalars.upperThreshold = max;
mesh.scalars.minColor = [0.69, 0.66, 0.91];
mesh.scalars.maxColor = [0.75, 0.60, 0.67];
mesh.modified();

This does not affect the display but dat.gui is lost for a threshold setting as:

var maxThresholdController = scalarsgui.add(mesh.scalars, 'upperThreshold',
   mesh.scalars.min, mesh.scalars.max);

I added a min/max find loop in the if (scalars ) { (L1132) of renderer3D.js which solves the problem. Is this correct or am I missing something?

[NicolasRannou]

Great,

Could you please submit a pull request so we can have a look?

Best
Nicolas

On Mon, May 19, 2014 at 4:03 AM, ivmartel notifications@github.com wrote:

Hi,
When setting the mesh scalars from an array (as suggested on L15 of lesson
12http://jsfiddle.net/gh/get/toolkit/edge/xtk/lessons/tree/master/12/#run),
it seems its min/max are not recalculated. I'm doing it this way:

mesh.scalars.array = xScalars;mesh.scalars.lowerThreshold = min;mesh.scalars.upperThreshold = max;mesh.scalars.minColor = [0.69, 0.66, 0.91];mesh.scalars.maxColor = [0.75, 0.60, 0.67];mesh.modified();

This does not affect the display but dat.gui is lost for a threshold
setting as:

var maxThresholdController = scalarsgui.add(mesh.scalars, 'upperThreshold',
mesh.scalars.min, mesh.scalars.max);

I added a min/max find loop in the if (scalars ) { (L1132https://github.com/xtk/X/blob/master/visualization/renderer3D.js#L1132)
of renderer3D.js which solves the problem. Is this correct or am I missing
something?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/152
.

[ivmartel]

I created a fiddle based on the cube example to demonstrate the problem. Interacting with the thresholds is difficult... It works better with the pull request I propose (#153).
And a comment/question, the colour gradient between the minimum and maximum seems to work better when the scalars range is [0,1]. Otherwise it saturates. New issue?