fix(getBrandId): parameterize text prompt#368
Open
kevinkace wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the themes CLI to allow getBrandId() to display different user prompts depending on the command (themes:list vs themes:import), addressing the misleading prompt reported in issue #367.
Changes:
- Parameterized
getBrandId()with a custom prompt message. - Updated
themes:listto use a list-specific brand selection prompt. - Updated
themes:importto use an import-specific brand selection prompt.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/zcli-themes/src/lib/getBrandId.ts | Adds a message parameter and uses it as the inquirer prompt text. |
| packages/zcli-themes/src/commands/themes/list.ts | Passes a list-appropriate prompt string into getBrandId(). |
| packages/zcli-themes/src/commands/themes/import.ts | Passes an import-appropriate prompt string into getBrandId(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Parameterize
getBrandId()so the the text prompt forthemes:listandthemes:importmatch how they are used.Do NOT write here! This section will be filled in by GitHub Action
automatically. If you don't want this, either remove the markers or write
outside the fences.
Detail
closes #367
Checklist