Skip to content

Commit cbfa87c

Browse files
authored
Merge pull request #25889 from mlugg/incremental-llvm-warn
compiler: warn when using -fincremental with LLVM backend
2 parents ca34abb + 13993c4 commit cbfa87c

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/main.zig

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -155,11 +155,8 @@ pub fn log(
155155
} else return;
156156
}
157157

158-
const prefix1 = comptime level.asText();
159-
const prefix2 = if (scope == .default) ": " else "(" ++ @tagName(scope) ++ "): ";
160-
161-
// Print the message to stderr, silently ignoring any errors
162-
std.debug.print(prefix1 ++ prefix2 ++ format ++ "\n", args);
158+
// Otherwise, use the default implementation.
159+
std.log.defaultLog(level, scope, format, args);
163160
}
164161

165162
var debug_allocator: std.heap.DebugAllocator(.{
@@ -3363,6 +3360,10 @@ fn buildOutputType(
33633360
fatal("--debug-incremental requires -fincremental", .{});
33643361
}
33653362

3363+
if (incremental and create_module.resolved_options.use_llvm) {
3364+
warn("-fincremental is currently unsupported by the LLVM backend; crashes or miscompilations are likely", .{});
3365+
}
3366+
33663367
const cache_mode: Compilation.CacheMode = b: {
33673368
// Once incremental compilation is the default, we'll want some smarter logic here,
33683369
// considering things like the backend in use and whether there's a ZCU.

0 commit comments

Comments
 (0)