Changed to a single regex

On the regex you can specify multiple conditions, so there is no reason to split by comma, which could be a character from the regex.

Author: jrbasso

README.md

@@ -6,7 +6,7 @@
 [![CodeQL](https://github.com/zumba/regex-match-commenter-action/actions/workflows/codeql-analysis.yml/badge.svg)](https://github.com/zumba/regex-match-commenter-action/actions/workflows/codeql-analysis.yml)
 [![Coverage](./badges/coverage.svg)](./badges/coverage.svg)
 
-This GitHub Action searches for specified regular expression patterns in the changes of a pull request. If matches are found, it can optionally mark the pull request for changes and add inline comments. If no matches are found, a comment is added to the pull request.
+This GitHub Action searches for specified regular expression pattern in the changes of a pull request. If matches are found, it can optionally mark the pull request for changes and add inline comments. If no matches are found, a comment is added to the pull request.
 
 Some use cases are for detecting PII changes on the code. For example, you can monitor if the words `email`, `phone`, `street`, `password`, etc. are part of the changes.
 The match uses regex, so you can also look for variables such as `\w+@\w+.\w+` to look for an actual e-mail address.
@@ -17,9 +17,9 @@ The match uses regex, so you can also look for variables such as `\w+@\w+.\w+` t
 
 **Required** GitHub token for authentication. Typically, this is the GitHub Actions token.
 
-### `regex_patterns`
+### `regex_pattern`
 
-**Required** A comma-separated list of regular expression patterns to search for in the pull request diff.
+**Required** A regular expression pattern to search for in the pull request diff.
 
 ### `diff_scope`
 
@@ -59,7 +59,7 @@ jobs:
       uses: zumba/regex-match-commenter-action@v1
       with:
         github_token: ${{ secrets.GITHUB_TOKEN }}
-        regex_patterns: 'email'
+        regex_pattern: 'email|phone'
         diff_scope: 'both'
         mark_changes_requested: false
         match_found_message: 'Attention needed.'

__tests__/main.test.ts

@@ -30,8 +30,8 @@ describe('action', () => {
       switch (name) {
         case 'github_token':
           return 'gh-token'
-        case 'regex_patterns':
-          return 'pattern1,pattern2'
+        case 'regex_pattern':
+          return 'pattern[12]'
         default:
           return ''
       }

action.yml

@@ -1,5 +1,5 @@
 name: 'Regex Match Commenter Action'
-description: 'Searches for regex patterns in PR diffs and comments on them'
+description: 'Searches for regex pattern in PR diffs and comments on them'
 author: 'Zumba'
 
 branding:
@@ -11,8 +11,8 @@ inputs:
     description: 'GitHub token'
     required: true
 
-  regex_patterns:
-    description: 'List of regex patterns to search for'
+  regex_pattern:
+    description: 'Javascript regex pattern to search for'
     required: true
 
   diff_scope:

dist/index.js

@@ -1,6 +1,6 @@
 {
   "name": "regex-match-commenter-action",
-  "description": "Searches for regex patterns in PR diffs and comments on them",
+  "description": "Searches for regex pattern in PR diffs and comments on them",
   "version": "0.0.0",
   "author": "",
   "private": true,

package-lock.json

@@ -14,9 +14,9 @@ enum DiffScope {
 export async function run(): Promise<void> {
   try {
     const token: string = core.getInput('github_token', { required: true })
-    const regexPatterns: string[] = core
-      .getInput('regex_patterns', { required: true })
-      .split(',')
+    const regexPattern: string = core.getInput('regex_pattern', {
+      required: true
+    })
     const diffScope: DiffScope = (core.getInput('diff_scope') ||
       'both') as DiffScope
     const markChangesRequested: boolean =
@@ -98,43 +98,41 @@ export async function run(): Promise<void> {
         ((diffScope === DiffScope.BOTH || diffScope === DiffScope.REMOVED) &&
           line.startsWith('-'))
       ) {
-        for (const pattern of regexPatterns) {
-          const regex = new RegExp(pattern)
-          if (regex.test(line)) {
-            // Before posting a new comment, check if it already exists
-            const isDuplicate = existingComments.data.some(
-              comment => comment.body === matchFoundMessage
-            )
-
-            if (!isDuplicate) {
-              core.debug(`Match found`)
-              foundMatches = true
-              const side = line.startsWith('+') ? 'RIGHT' : 'LEFT'
-              const requestParams = {
-                owner,
-                repo,
-                pull_number: pullRequestNumber,
-                body: matchFoundMessage,
-                commit_id: context.payload.pull_request.head.sha,
-                path: currentFile,
-                side,
-                line: side === 'LEFT' ? oldLineNumber : newLineNumber
-              }
-              core.debug(JSON.stringify(requestParams))
+        const regex = new RegExp(regexPattern)
+        if (regex.test(line)) {
+          // Before posting a new comment, check if it already exists
+          const isDuplicate = existingComments.data.some(
+            comment => comment.body === matchFoundMessage
+          )
 
-              await octokit.rest.pulls.createReviewComment({
-                owner,
-                repo,
-                pull_number: pullRequestNumber,
-                body: matchFoundMessage,
-                commit_id: context.payload.pull_request.head.sha,
-                path: currentFile,
-                side,
-                line: side === 'LEFT' ? oldLineNumber : newLineNumber
-              })
-            } else {
-              core.debug(`Match found but already commented`)
+          if (!isDuplicate) {
+            core.debug(`Match found`)
+            foundMatches = true
+            const side = line.startsWith('+') ? 'RIGHT' : 'LEFT'
+            const requestParams = {
+              owner,
+              repo,
+              pull_number: pullRequestNumber,
+              body: matchFoundMessage,
+              commit_id: context.payload.pull_request.head.sha,
+              path: currentFile,
+              side,
+              line: side === 'LEFT' ? oldLineNumber : newLineNumber
             }
+            core.debug(JSON.stringify(requestParams))
+
+            await octokit.rest.pulls.createReviewComment({
+              owner,
+              repo,
+              pull_number: pullRequestNumber,
+              body: matchFoundMessage,
+              commit_id: context.payload.pull_request.head.sha,
+              path: currentFile,
+              side,
+              line: side === 'LEFT' ? oldLineNumber : newLineNumber
+            })
+          } else {
+            core.debug(`Match found but already commented`)
           }
         }
       }