fix: ensure tutorial addresses are deployed on both testnet and devnet#176
Closed
Keinberger wants to merge 1 commit intomainfrom
Closed
fix: ensure tutorial addresses are deployed on both testnet and devnet#176Keinberger wants to merge 1 commit intomainfrom
Keinberger wants to merge 1 commit intomainfrom
Conversation
- Update counter contract address in code and docs to single deployed instance (mtst1az62d8rhnf00kqp80k3klwy56c6w9gvm) - Fix oracle tutorial prose/code mismatch for prefix.suffix values - Add Pragma dependency comments to oracle_reader.masm
Keinberger
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before a testnet upgrade, we need to test all tutorials against devnet since testnet won't be running the next release version yet. This requires that any hardcoded account addresses referenced by tutorials exist on both networks.
This PR deploys the counter contract with a deterministic seed on both testnet and devnet and updates all eight references (two in code, six in docs) to the new unified address (
mtst1az62d8rhnf00kqp80k3klwy56c6w9gvm). The address works on both networks sinceAccountId::from_bech32discards the network prefix and the deterministic seed produces the sameAccountIdregardless of network.Also fixes a prose/code mismatch in the oracle tutorial where the inline
prefix.suffixvalues didn't match the MASM file, and adds a Pragma dependency comment tooracle_reader.masm.Closes #175