refactor: adopt MaybeSend portability vocabulary - #2229
Draft
gold-silver-copper wants to merge 1 commit into
Draft
refactor: adopt MaybeSend portability vocabulary#2229gold-silver-copper wants to merge 1 commit into
gold-silver-copper wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopt MaybeSend portability vocabulary
Description
This refactors Rig's cross-platform async portability vocabulary to conventional Rust naming while preserving the exact existing behavior.
WasmCompatSend,WasmCompatSync, andWasmBoxedFuturetoMaybeSend,MaybeSync, andBoxFuture.all(target_arch = "wasm32", target_os = "unknown"); WASI and every other target retain realSend/Syncguarantees.BoxFuturewithfutures::future::BoxFutureorLocalBoxFuture.BoxStream/LocalBoxStreamaliases.This is intentionally a breaking API rename with no compatibility shims.
Type of change
Testing
cargo fmt --all --checkcargo clippy --all-targets --all-features -- -D warningscargo testcargo check -p rig-core --target wasm32-unknown-unknowncargo check -p rig-agent --target wasm32-unknown-unknowncargo check -p rig --target wasm32-unknown-unknowncargo doc --workspace --no-depsChecklist
Notes
A fresh independent review covered the complete diff. Its one finding—a stale compatibility name in a comment—was fixed, affected checks were rerun, and the final independent pass found no remaining actionable issues.
Two broader pre-existing target limitations remain outside this PR's scope:
rig-core --all-featureson browser WASM is blocked bylopdf→getrandomwithoutwasm_js.socket2target support.