[BUGFIX] Suppression du freeze au chargement d'un gros fichier JSON (PIX-22512)#83
Closed
aurelie-crouillebois wants to merge 2 commits into
Closed
[BUGFIX] Suppression du freeze au chargement d'un gros fichier JSON (PIX-22512)#83aurelie-crouillebois wants to merge 2 commits into
aurelie-crouillebois wants to merge 2 commits into
Conversation
dianeCdrPix
changed the title
dianeCdrPix
force-pushed
the
tech-accelerate-json-parse
branch
from
ac0abf7 to
a832bdd
Compare
dianeCdrPix
force-pushed
the
tech-accelerate-json-parse
branch
from
a832bdd to
8b81680
Compare
Contributor
|
Lors du tech time nous avions cru que c'était le JSON.parse qui prenait du temps. On s'est fait avoir par l'utilisation du console.time() qui nous a induits en erreur. En réalité c'est l'utilisation de jsoneditor, et plus particulièrement la génération du DOM du formulaire qui est coûteuse. L'ajout d'une librairie supplémentaire pour un gain marginal ne me semble pas indispensable. Je propose de clôturer cette PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌱 Problème
Lors de l'ouverture d'un gros module JSON, l'écran freeze. Après plusieurs tests, cela provient notamment du temps pris pour parser le Json.
🐣 Proposition
editor.getValue()dans un handler🐝 Pour tester
Ouvrir un méga GROS fichier JSON. Pas de freeze observé sur l'interface (ou très court).