Create stub instead of mock in the getWillReturn method#39
Merged
frankdekker merged 6 commits intomasterfrom Mar 6, 2026
Merged
Create stub instead of mock in the getWillReturn method#39frankdekker merged 6 commits intomasterfrom
frankdekker merged 6 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Symfony testing helpers so that FormAssertion::getWillReturn() returns a test double intended to behave like a stub for child forms, and adjusts AbstractControllerTestCase::expectCreateForm() to match the new FormAssertion constructor.
Changes:
- Replaced
MockBuilderusage inFormAssertion::getWillReturn()with aMockObject\Generator\Generator::testDouble()-based test double. - Removed the
TestCasedependency fromFormAssertionand updatedexpectCreateForm()accordingly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Symfony/Helper/FormAssertion.php | Switches child-form creation in getWillReturn() to a generated test double and drops the stored TestCase. |
| src/Symfony/AbstractControllerTestCase.php | Updates FormAssertion instantiation to match the new constructor signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bram123
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.