Feature/partial fill premium - #228
Closed
ifelsedeveloper wants to merge 6 commits into
Closed
ifelsedeveloper wants to merge 6 commits into
ifelsedeveloper wants to merge 6 commits into
Conversation
Move-only change: _getRateBump and _getAuctionBump leave SimpleSettlement for an abstract base with internal virtual visibility, so a standalone extension can reuse the time-curve math. No behavior change. Co-authored-by: Sergej Kunz <info@deacix.de>
- Introduced PartialFillPremiumAuction contract to allow for premium pricing on partial fills. - Updated SimpleSettlement to inherit from PartialFillPremiumAuction, enabling the new pricing model. - Refactored auction detail parsing to accommodate fill curves and net bumps. - Enhanced helper functions to support the new fill premium logic in auction calculations. - Added tests for the new auction behavior, ensuring correct pricing based on fill shares.
ifelsedeveloper
marked this pull request as draft
August 14, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What does this PR change?
Draft pr