Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This change adds runtime peer management so an operator can add or remove trusted active nodes, disconnect a peer, and block malicious IP addresses without restarting the service.
Changes
addActiveNode,removeActiveNode,disconnect, andreplaceBlockedIpstoP2pService.activeNodessafe for concurrent iteration and runtime updates withCopyOnWriteArrayList.P2pConfig.blockedIpswith a defensive copy. Persistent storage remains the caller's responsibility.DisconnectReason.REQUESTED(0x0F) for an operator-requested endpoint disconnect. Blocklist-driven disconnects remain silent so the policy is not disclosed to a potentially malicious peer.-b/--blocked-ipssupport toStartAppand document active-node and blocked-IP parameters in the example README.Scope
The first phase applies the manual blocklist to TCP connections only. UDP/Kademlia and DNS discovery are not filtered directly and may still return blocked addresses; those addresses are rejected before a TCP connection is scheduled or admitted. Endpoint disconnect remains an exact IP-and-port operation. CIDR rules and blocklist persistence remain outside libp2p.
Testing
Unit tests cover runtime active-node updates and retry behavior, exact endpoint disconnection and
REQUESTEDencoding, silent blocklist disconnects, blocked-IP replacement and configuration synchronization, concurrent-safe snapshots, IP normalization, inbound and outbound TCP rejection, endpoint validation including loopback support,StartAppparsing, and deterministic connection-pool behavior.