Skip to content

profile add <url>: skip message shows temp filename instead of the source file name #136

Description

@8bitAlex

Found during the v1.0.0 manual test plan (item 1.5). Verified on 0.18.0 @ main (f5afadf).

Repro

raid profile add https://raw.githubusercontent.com/8bitalex/raid/main/raid.yaml
# Skipping raid-profile-1231891883.yaml: invalid profile (...)

The skip line names the local temp file (filepath.Base(tmpPath) in src/cmd/profile/fetch.go) rather than anything the user recognizes. The git-clone path prints real filenames; only the raw-HTTP path leaks the temp name.

Fix

Carry the URL's basename (or the full URL) through to the skip message for HTTP downloads.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions