Repository navigation
Catch only read errors when loading KnowMe data - #14
Open
ranas-mukminov wants to merge 1 commit into
Open
ranas-mukminov wants to merge 1 commit into
ranas-mukminov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KnowMe sync reads its data file with a bare except even though its own error message names the two expected failures, a missing file and invalid data, so any other error is silently reported as a read problem. This narrows the handler to OSError and JSONDecodeError, the two failures the message describes, and lets anything else surface. The edited file passes py_compile; no test suite was run here, so CI is the check.