Skip to content

fix(rocm): keep the mps-parser wheel from including WheelHelpers via the wrong source dir #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
awelling2801 merged 1 commit into from
Oct 7, 2026
Merged

fix(rocm): keep the mps-parser wheel from including WheelHelpers via the wrong source dir #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions python/cuopt/cuopt/linear_programming/data_model/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,23 @@ rapids_cython_create_modules(SOURCE_FILES "${cython_sources}" LINKED_LIBRARIES "

# data_model_wrapper's compiled extension module is built with
# INSTALL_RPATH=$ORIGIN, i.e. it expects libmps_parser.so to live right next
# to it in the installed wheel. cuopt::mps_parser (an IMPORTED target --
# see the parent CMakeLists.txt) was never actually copied there, which
# to it in the installed cuopt wheel. cuopt::mps_parser (an IMPORTED target --
# see python/cuopt/CMakeLists.txt) was never actually copied there, which
# made `from cuopt.linear_programming.data_model import data_model_wrapper`
# (and therefore `import cuopt`) fail at runtime with
# "libmps_parser.so: cannot open shared object file".
include(${CMAKE_SOURCE_DIR}/cmake/Modules/WheelHelpers.cmake)
install_aliased_imported_targets(
TARGETS cuopt::mps_parser
DESTINATION cuopt/linear_programming/data_model
)
#
# This directory is also add_subdirectory()'d by the standalone
# mpsparser-python project (rocopt_mps_parser). That project's
# CMAKE_SOURCE_DIR is python/cuopt/cuopt/linear_programming, which has no
# cmake/Modules/WheelHelpers.cmake, so a CMAKE_SOURCE_DIR-relative include
# fails the wheel build. WheelHelpers.cmake lives in the cuopt Python
# project; the mps-parser project already installs libmps_parser.so beside
# its own extensions and must not install into the cuopt wheel layout.
if(PROJECT_NAME STREQUAL "cuopt-python")
include(${CMAKE_CURRENT_LIST_DIR}/../../../cmake/Modules/WheelHelpers.cmake)
install_aliased_imported_targets(
TARGETS cuopt::mps_parser
DESTINATION cuopt/linear_programming/data_model
)
endif()