Skip to content

RTT example - allow empty lines too #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 19, 2024
Merged

RTT example - allow empty lines too #116

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c882b1e
allow empty lines too
fanoush Sep 5, 2024
ebfe8f9
fix also cmd being empty on empty line
fanoush Sep 5, 2024
fb714ef
Merge branch 'master' into f-rtt-allow-empty-lines
thegecko Sep 28, 2024
fd8a34e
remove commented code
fanoush Sep 30, 2024
c5792ea
Merge branch 'master' into f-rtt-allow-empty-lines
thegecko Oct 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions examples/rtt/web.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,13 @@
const printable = !ev.altKey && !ev.ctrlKey && !ev.metaKey;

if (ev.keyCode === 13) { // process newline
if (line_input.length) {
// allow empty lines too
// if (line_input.length) {
term.write('\r\n');
cmd = line_input;
cmd = line_input + "\r\n";
console.log('sending: \"' + line_input + '\"');
line_input = "";
}
//}
} else if (ev.keyCode === 8) { // process backspace
if (term._core.buffer.x > 0) {
term.write('\b \b');
Expand Down Expand Up @@ -164,7 +165,7 @@

// send to target
if (cmd.length) {
cmdBytes = new TextEncoder().encode(cmd + "\r\n");
cmdBytes = new TextEncoder().encode(cmd);
ret = await rtt.write(0, cmdBytes);
if (ret < 0)
console.log("cannot write", cmdBytes, "chars");
Expand Down