Skip to content

fix for uploading multiple attachments in one editing session #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evgenyfadeev merged 1 commit into from
Aug 3, 2026
Merged

fix for uploading multiple attachments in one editing session #970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion askbot/media/wmd/wmd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,11 @@ var WmdUploadDialog = function (opts) {
this._makeLinkMarkdown = opts.makeLinkMarkdown;

this.setFileType(opts.dialogType === 'file' ? 'attachment' : 'image');
this.setInputId(util.makeId('file-upload'));
// Counter ensures each dialog instance gets a unique file-input ID.
// Never decremented: monotonic growth guarantees no ID collisions,
// even if the modal:after-close DOM cleanup hasn't fired yet.
WmdUploadDialog._counter += 1;
this.setInputId(util.makeId('file-upload-' + WmdUploadDialog._counter));
this._headerEnabled = true;
this.setHeadingText(opts.headingText);

Expand All @@ -310,6 +314,7 @@ var WmdUploadDialog = function (opts) {
}
};
inherits(WmdUploadDialog, FileUploadDialog);
WmdUploadDialog._counter = 0;

WmdUploadDialog.prototype.createDom = function () {
var me = this;
Expand All @@ -326,6 +331,10 @@ WmdUploadDialog.prototype.createDom = function () {

WmdUploadDialog.superClass_.createDom.call(this);

this._element.on('modal:after-close', function () {
me._element.remove();
});

// Override reject handler to also notify makeLinkMarkdown.
// Must rebind the button because super createDom() already bound the original.
var originalReject = me._reject_handler;
Expand Down
Loading