Fix spurious PyBindImath testEuler failure - #584
Merged
Conversation
`assert e.order() == EULER_XYZ` fails (sometimes!?) when `e` is of type `Eulerd` because `EULER_XYZ` is an enum type of `Eulerf`. This changes the `order()` method to return `Eulerf` values even for `Eulerd`, so both classes operates with a common enum type. Same for axis and layout enums. Assisted-by: GitHub Copilot CLI (model: Claude Sonnet 5) Signed-off-by: Cary Phillips <seabeepea@gmail.com>
Member
Author
|
The pybind11 code is not part of the official distribution, and the long-term plan is to deprecated it entirely, so this is essentially dead code. But for now it seemed appropriate to resolve the issues. I'm going to merge this as is. |
cary-ilm
added a commit
that referenced
this pull request
Aug 17, 2026
`assert e.order() == EULER_XYZ` fails (sometimes!?) when `e` is of type `Eulerd` because `EULER_XYZ` is an enum type of `Eulerf`. This changes the `order()` method to return `Eulerf` values even for `Eulerd`, so both classes operates with a common enum type. Same for axis and layout enums. Assisted-by: GitHub Copilot CLI (model: Claude Sonnet 5) Signed-off-by: Cary Phillips <seabeepea@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assert e.order() == EULER_XYZfails (sometimes!?) wheneis of typeEulerdbecauseEULER_XYZis an enum type ofEulerf.This changes the
order()method to returnEulerfvalues even forEulerd, so both classes operates with a common enum type.Same for axis and layout enums.
Assisted-by: GitHub Copilot CLI (model: Claude Sonnet 5)