Skip to content

feat: added executor tests #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RohitKushvaha01 wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: added executor tests #1816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3403337
feat: added executor tests
RohitKushvaha01 Jan 13, 2026
2edc3db
Update src/test/exec.tests.js
RohitKushvaha01 Jan 13, 2026
3502ba5
feat: added executor tests
RohitKushvaha01 Jan 13, 2026
3bedaa2
feat: added delay
RohitKushvaha01 Jan 13, 2026
d332a98
feat: added missing import
RohitKushvaha01 Jan 13, 2026
9dd7c25
feat: removed missing import
RohitKushvaha01 Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
176 changes: 176 additions & 0 deletions src/test/exec.tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,176 @@
import { TestRunner } from "./tester";

export async function runExecutorTests(writeOutput) {
const runner = new TestRunner("Executor API Tests");

runner.test("Executor available", async (test) => {
test.assert(typeof Executor !== "undefined", "Executor should be available globally");
});

runner.test("Background Executor available", async (test) => {
test.assert(typeof Executor.BackgroundExecutor !== "undefined", "Background Executor should be available globally");
});


runner.test("execute()", async (test) => {

test.assert(
await Executor.execute("echo test123").includes("test123"),
"Command output should match"
);

});



runner.test("execute() (BackgroundExecutor)", async (test) => {

test.assert(
await Executor.BackgroundExecutor.execute("echo test123").includes("test123"),
"Command output should match"
);

});

runner.test("start()", async (test) => {
let stdout = "";

const uuid = await Executor.start("sh", (type, data) => {
if (type === "stdout") stdout += data;
});

await Executor.write(uuid, "echo hello\n");
await new Promise(r => setTimeout(r, 200));
await Executor.stop(uuid);

await new Promise(r => setTimeout(r, 200));

test.assert(stdout.includes("hello"), "Shell should echo output");
});


runner.test("start() (BackgroundExecutor)", async (test) => {
let stdout = "";

const uuid = await Executor.BackgroundExecutor.start("sh", (type, data) => {
if (type === "stdout") stdout += data;
});

await Executor.BackgroundExecutor.write(uuid, "echo hello\n");
await new Promise(r => setTimeout(r, 200));
await Executor.BackgroundExecutor.stop(uuid);

await new Promise(r => setTimeout(r, 200));

test.assert(stdout.includes("hello"), "Shell should echo output");
});


runner.test("start/stop()", async (test) => {
let stdout = "";

const uuid = await Executor.start("sh", (type, data) => {

});

await new Promise(r => setTimeout(r, 200));



const isRunning = await Executor.isRunning(uuid);

test.assert(isRunning === true, "Executor must be running");


await new Promise(r => setTimeout(r, 200));


await Executor.stop(uuid);

await new Promise(r => setTimeout(r, 200));

test.assert(await Executor.isRunning(uuid) === false, "Executor must be stopped");

});

runner.test("start/stop() (BackgroundExecutor)", async (test) => {
let stdout = "";

const uuid = await Executor.BackgroundExecutor.start("sh", (type, data) => {

});

await new Promise(r => setTimeout(r, 200));



const isRunning = await Executor.BackgroundExecutor.isRunning(uuid);

test.assert(isRunning === true, "Executor must be running");


await new Promise(r => setTimeout(r, 200));


await Executor.BackgroundExecutor.stop(uuid);

await new Promise(r => setTimeout(r, 200));


test.assert(isRunning !== await Executor.BackgroundExecutor.isRunning(uuid), "Executor must be stopped");
test.assert(await Executor.BackgroundExecutor.isRunning(uuid) === false, "Executor must be stopped");

});






runner.test("start/stop()", async (test) => {
let stdout = "";

const uuid = await Executor.start("sh", (type, data) => {

});

await new Promise(r => setTimeout(r, 200));



const isRunning = await Executor.isRunning(uuid);

test.assert(isRunning === true, "Executor must be running");


await new Promise(r => setTimeout(r, 200));


await Executor.stop(uuid);

await new Promise(r => setTimeout(r, 200));

test.assert(await Executor.isRunning(uuid) === false, "Executor must be stopped");

});

runner.test("FDROID env variable", async (test) => {
const result = await Executor.execute("echo $FDROID");

const isSet = result.trim().length > 0;

test.assert(
isSet,
"FDROID env variable should be set"
);
});
Comment on lines +157 to +166
Copy link

@greptile-apps greptile-apps bot Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Environment-dependent test: This test assumes the FDROID environment variable is always set and has a non-empty value. However, this may not be true in all test environments (e.g., local development, CI/CD pipelines, non-F-Droid builds).

Consider using test.skip() if the environment variable isn't set, or adjust the assertion to handle cases where the variable legitimately might not exist: test.assert(typeof result === 'string', "FDROID env variable should be accessible")

Prompt To Fix With AI 
This is a comment left during a code review.
Path: src/test/exec.tests.js
Line: 160:169

Comment:
Environment-dependent test: This test assumes the FDROID environment variable is always set and has a non-empty value. However, this may not be true in all test environments (e.g., local development, CI/CD pipelines, non-F-Droid builds).

Consider using `test.skip()` if the environment variable isn't set, or adjust the assertion to handle cases where the variable legitimately might not exist: `test.assert(typeof result === 'string', "FDROID env variable should be accessible")`

How can I resolve this? If you propose a fix, please make it concise.









return await runner.run(writeOutput);
}
86 changes: 65 additions & 21 deletions src/test/tester.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
import { runAceEditorTests } from "./editor.tests";

import { runExecutorTests } from "./exec.tests";
import { runSanityTests } from "./sanity.tests";
import { runAceEditorTests } from "./editor.tests";


export async function runAllTests() {
const terminal = acode.require("terminal");
Expand All @@ -16,6 +19,7 @@ export async function runAllTests() {
// Run unit tests
await runSanityTests(write);
await runAceEditorTests(write);
await runExecutorTests(write);

write("\x1b[36m\x1b[1mTests completed!\x1b[0m\n");
} catch (error) {
Expand Down Expand Up @@ -80,6 +84,7 @@ class TestRunner {
this.passed = 0;
this.failed = 0;
this.results = [];
this.skipped = 0;
}

/**
Expand All @@ -104,6 +109,11 @@ class TestRunner {
}
}

skip(reason = "Skipped") {
throw new SkipTest(reason);
}


async _runWithTimeout(fn, ctx, timeoutMs) {
return new Promise((resolve, reject) => {
let finished = false;
Expand Down Expand Up @@ -161,48 +171,73 @@ class TestRunner {

try {
await delay(200);

await this._runWithTimeout(test.fn, this, 3000);

stopSpinner();

this.passed++;
this.results.push({ name: test.name, status: "PASS", error: null });
this.results.push({ name: test.name, status: "PASS" });
line(` ${COLORS.GREEN}✓${COLORS.RESET} ${test.name}`, COLORS.GREEN);

} catch (error) {
stopSpinner();

this.failed++;
this.results.push({
name: test.name,
status: "FAIL",
error: error.message,
});
line(
` ${COLORS.RED}✗${COLORS.RESET} ${test.name}`,
COLORS.RED + COLORS.BRIGHT,
);
line(
` ${COLORS.DIM}└─ ${error.message}${COLORS.RESET}`,
COLORS.RED + COLORS.DIM,
);
if (error instanceof SkipTest) {
this.skipped++;
this.results.push({
name: test.name,
status: "SKIP",
reason: error.message,
});

line(
` ${COLORS.YELLOW}?${COLORS.RESET} ${test.name}`,
COLORS.YELLOW + COLORS.BRIGHT,
);
line(
` ${COLORS.DIM}└─ ${error.message}${COLORS.RESET}`,
COLORS.YELLOW + COLORS.DIM,
);
} else {
this.failed++;
this.results.push({
name: test.name,
status: "FAIL",
error: error.message,
});

line(
` ${COLORS.RED}✗${COLORS.RESET} ${test.name}`,
COLORS.RED + COLORS.BRIGHT,
);
line(
` ${COLORS.DIM}└─ ${error.message}${COLORS.RESET}`,
COLORS.RED + COLORS.DIM,
);
}
}

}

// Summary
line();
line("─────────────────────────────────────────────", COLORS.GRAY);

const total = this.tests.length;
const percentage = total ? ((this.passed / total) * 100).toFixed(1) : "0.0";
const effectiveTotal = total - this.skipped;

const percentage = effectiveTotal
? ((this.passed / effectiveTotal) * 100).toFixed(1)
: "0.0";


const statusColor = this.failed === 0 ? COLORS.GREEN : COLORS.YELLOW;

line(
` Tests: ${COLORS.BRIGHT}${total}${COLORS.RESET} | ` +
`${statusColor}Passed: ${this.passed}${COLORS.RESET} | ` +
`${COLORS.RED}Failed: ${this.failed}${COLORS.RESET}`,
statusColor,
`${COLORS.GREEN}Passed: ${this.passed}${COLORS.RESET} | ` +
`${COLORS.YELLOW}Skipped: ${this.skipped}${COLORS.RESET} | ` +
`${COLORS.RED}Failed: ${this.failed}${COLORS.RESET}`,
);

line(
Expand All @@ -226,4 +261,13 @@ class TestRunner {
}
}


class SkipTest extends Error {
constructor(message = "Skipped") {
super(message);
this.name = "SkipTest";
}
}


export { TestRunner };
Loading