Skip to content

Conversation

@musicinmybrain
Copy link
Contributor

@musicinmybrain musicinmybrain commented Nov 23, 2025

Update the dirs dependency to the latest version, 6.0.0.

The SemVer-breaking change in dirs 6 is just that dirs-sys is updated to 0.5, which, in turn, is just due to updating some platform-specific dependencies. There are therefore no API changes we need to worry about here.


Important

Update dirs dependency to version 6.0.0 in aw-client-rust and aw-sync projects, with no API changes required.

  • Dependencies:
    • Update dirs to version 6.0.0 in aw-client-rust/Cargo.toml and aw-sync/Cargo.toml.
    • Update Cargo.lock to reflect dirs version 6.0.0 and dirs-sys version 0.5.0.
  • Misc:
    • No API changes required due to the update.

This description was created by Ellipsis for b582baa. You can customize this summary. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to b582baa in 1 minute and 21 seconds. Click for details.
  • Reviewed 311 lines of code in 3 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. aw-client-rust/Cargo.toml:20
  • Draft comment:
    Consider aligning the version string for the 'dirs' dependency for consistency (e.g. use '6.0.0' as in other modules).
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. aw-client-rust/Cargo.toml:27
  • Draft comment:
    Avoid using the wildcard '*' for 'tokio-test'; consider pinning it to a specific version range to prevent unexpected breaks.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. aw-sync/Cargo.toml:25
  • Draft comment:
    Verify if the 'gethostname' version should match across modules—'aw-sync' uses '0.4.3' while 'aw-client-rust' uses '0.4'.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_CIkaZqlBLkvdKOqJ

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@ErikBjare ErikBjare changed the title Update dirs to version 6 build(deps): update dirs to version 6 Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.66%. Comparing base (656f3c9) to head (b582baa).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   70.81%   69.66%   -1.16%     
==========================================
  Files          51       54       +3     
  Lines        2916     3145     +229     
==========================================
+ Hits         2065     2191     +126     
- Misses        851      954     +103     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ErikBjare ErikBjare merged commit 1a22daa into ActivityWatch:master Nov 24, 2025
7 checks passed
@ErikBjare
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants