Skip to content

Conversation

@SENya1990
Copy link
Collaborator

@SENya1990 SENya1990 commented Jan 18, 2026

MERGE ONLY AFTER PR #653

Changes Overview

  • enhanced parameters comparison to check ref kinds of parameters
  • enhanced return types comparisons to check ref kinds of return types
  • added unit test for PX1096 to test signature mismatch for ref/out parameters

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of ref and out parameters in method signature comparison logic to properly detect signature mismatches in PXOverride methods.

Changes:

  • Enhanced method signature comparison to check RefKind property for both methods and parameters
  • Added parameter equality checks for RefKind and IsOptional properties with fallback to OriginalDefinition comparison
  • Added test case verifying detection of ref/out parameter mismatches in PXOverride methods

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
IMethodSymbolExtensions.cs Enhanced signature comparison to check RefKind for methods and parameters, including IsOptional checks
AcumaticaOverridesHelper.cs Added RefKind validation when comparing base delegate parameters
PXOverrideRefAndOutParametersMismatch.cs Test source demonstrating ref/out parameter mismatch scenario
PXOverrideMismatchTests.cs Added test case to verify ref/out parameter mismatch detection

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Base automatically changed from bugfix/ATR-941-dev-PX1102-false-alert to dev January 19, 2026 09:51
@SENya1990 SENya1990 changed the title Bugfix/atr 942 dev px1098 handle out and ref parameters PX1096 does not detect incompatibility in ref/out parameters Jan 19, 2026
@SENya1990 SENya1990 merged commit 53a61f8 into dev Jan 19, 2026
@SENya1990 SENya1990 deleted the bugfix/ATR-942-dev-PX1098-handle-out-and-ref-parameters branch January 19, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants