use short-circuit where possible

[pjljvandelaar]

Dear Gnatcoll developers,

According to adaic
short circuit operators should be preferred.
However, in case of side effects in the second/right argument the replacement is NOT equivalent.

The rejuvenation library has detected where logical operators can be replaced by short-circuit ones
and replaced them.

Greetings,
Pierre

Problem detected and solved by Rejuvenation-Ada crate

[CLAassistant]

All committers have signed the CLA.

[pjljvandelaar]

Added a second commit that prefers membership test.
Unfortunately I could not make a separate pull request for it.

[t-14]

Please remove code reformatting, and preserve formatting logic in sections that are being refactored.

[pjljvandelaar]

How would you want this code to be rewritten?
given that you want remove code reformatting, and preserve formatting logic in sections that are being refactored.

Note that the newly rewritten code must be pretty printed,
since otherwise the rewritten code might violate style rules (as specified in the project file).

[pjljvandelaar]

In this case a too long line is certainly possible ;-)

[t-14]

I am referring to places where reformatting is not motivated by anything, like gnatcoll-memory.adb:291

[t-14]

How would you want this code to be rewritten?

In this specific case, try to keep the same terms on each line as it was previously. We used to have one line for latin-3 and another for latin-4, your patch reformats it so references to latin-4 are on two different lines, this harms readability.

[pjljvandelaar]

You did however not turn off pretty printing,
so running the pretty printer might have changed your constraints.

It is an automated change, but it is a nice case of requirements for rewriting existing code.

[t-14]

You did however not turn off pretty printing,

I don't understand. "turn off pretty printing" where? gnatcoll is obviously hand-formatted.