Skip to content

Conversation

@git-hulk
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 25, 2025 03:55
@git-hulk git-hulk requested a review from Lance726 December 25, 2025 03:56
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for parsing the Tuple type in DDL (Data Definition Language) statements. Previously, the parser could handle Tuple types in query/expression contexts (e.g., type casting), but not in table column definitions.

Key Changes

  • Added Tuple type recognition in the DDL column type parser
  • Tuple types with named fields are now parsed using the same parseNestedType function used for Nested types
  • Added comprehensive test coverage with complex nested structures including Tuple types within Arrays and containing Maps

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
parser/parser_column.go Added Tuple type case to parseColumnType function, directing it to use parseNestedType for parsing named tuple fields
parser/testdata/ddl/create_with_time_zone.sql New test file demonstrating Tuple type usage in CREATE TABLE statements with named fields
parser/testdata/ddl/format/create_with_time_zone.sql Test file showing both original and formatted SQL for the Tuple type
parser/testdata/ddl/output/create_with_time_zone.sql.golden.json Expected parser output showing Tuple types correctly parsed as NestedType structures with Columns array

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@git-hulk git-hulk merged commit b233fe1 into AfterShip:master Dec 25, 2025
7 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20498565699

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 51.11%

Totals Coverage Status
Change from base Build 20060084019: 0.006%
Covered Lines: 7987
Relevant Lines: 15627

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants