feat(ja.soraraw): split stacked chapter images into pages - #697
Draft
kinboy56 wants to merge 8 commits into
Draft
Conversation
Contributor
|
since this depends on a fix that is not in a public app version, we should wait to merge until the next app release. the minimum app version should be set to whatever the next version release is. |
kinboy56
marked this pull request as draft
August 16, 2026 20:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some chapters here ship as one image with every page stacked on top of each other, up to 49152
pixels tall. Version 2 refused those with an error. This splits them instead.
get_page_listmeasures the image header and expands a stacked image into one page per stackedpage. The extension doesn't say whether the file is jpeg or webp, so the magic bytes decide.
PageImageProcessorcuts the slice each page asks for.minAppVersionis now0.8.5and the source version3. It depends on two fixes thatlanded after v0.8.4:
e44d774: drawing into a canvas shorter than the source image.3fd2913: pages sharing a url and differing only by theirPageContextall rendered thesame image.
Tell me if the next release will be numbered otherwise and I will change it.
3fd2913is also whatlet the
?slice=Nworkaround the earlier revision carried go, so the image is now fetched once perchapter rather than once per page.
Device testing covered the
?slice=Nrevision (iPhone 15, iOS 26.1).The current one needs a run on a nightly carrying
3fd2913