chore: add .catalog/catalog-info.yaml - #2
Merged
Conversation
alaudabot
requested changes
Apr 29, 2026
|
|
||
| acp.cpaas.io/functional-attributes: plugin | ||
| spec: | ||
| type: service |
There was a problem hiding this comment.
Critical Issue (bug/configuration): The system field incorrectly includes the "system:" prefix. It should be system: devops-tools (without the prefix), since the System's metadata name is already devops-tools. The current value system: system:devops-tools will cause Backstage to look for a non-existent system named "system:devops-tools`.
Suggested change
| type: service | |
| system: devops-tools |
| acp.cpaas.io/open-source-component-repo: https://github.com/goharbor/distribution | ||
| # 开源组件的版本信息，只适用于开源组件，自研组件默认不收集版本信息,格式 ${version} | ||
| acp.cpaas.io/open-source-component-version: v2.8.3 | ||
| # 开源组件的license信息,格式 ${license} |
There was a problem hiding this comment.
Suggestion (style/consistency): The annotation comments are in Chinese while the codebase typically uses English. Consider standardizing to English for consistency with other AlaudaDevops repositories.
🤖 AI Code Review
SummaryThis PR adds a Backstage catalog-info.yaml file defining the goharbor-distribution component and devops-tools system. The file follows Backstage catalog conventions, but there is a critical issue on line 24 where the system reference incorrectly includes a "system:" prefix that should be removed. Review Statistics
Critical Issues
Suggestions
Positive Feedback
ℹ️ About this reviewThis review was automatically generated using the
|
chengjingtao
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing