module_8

[Alex-Ozun]

No description provided.

[JackMeadDev]

Nice work, I can see your pipeline reporting success for your deployment and your image existing happily in DockerHub 👍 One thing to note is that I can't check the deployment actually works though, because there's no record anywhere of what your Heroku app website actually is so it would be good to add that to your docs! Once that's done, happy for you to merge when you're ready 😄

Definitely no harm here, but worth noting that the others in your cohort will largely be following the updated exercises here so for M10 onwards I'd recommend that (but this is just a different route to the same end goal as the newer M8/M9 exercises)

[JackMeadDev]

No real point pulling the image here - even if someone had changed it between the last step and this one, it's not obvious to me that we'd want to release their version of the image

[JackMeadDev]

Very minor, but you can combine these by asking docker to use the --all-tags flag so that it pushes both of these at once:

Suggested change

	- name: Push commit hash tagged build to Docker Hub
	run: docker push $DOCKER_USERNAME/todo-app-production:${GITHUB_SHA::6}
	- name: Push latest tagged build to Docker Hub
	run: docker push $DOCKER_USERNAME/todo-app-production:latest
	- name: Push tagged builds to Docker Hub
	run: docker push $DOCKER_USERNAME/todo-app-production:${GITHUB_SHA::6} --all-tags

[Alex-Ozun]

@JackMead

there's no record anywhere of what your Heroku app website actually is so it would be good to add that to your docs! Once that's done, happy for you to merge when you're ready

I'd actually deactivated the Heroku app for the time being, shortly after opening this PR since Heroku started billing me. Yeah, I'm that cheap 😅