Skip to content

use nmcli implementation for calculating WiFi signal strength #5201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alexays merged 2 commits into from
Jul 16, 2026
+9 −12
Merged

use nmcli implementation for calculating WiFi signal strength #5201

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73fdafb
use nmcli implementation for calculating signal strength
grishatop1 Jul 15, 2026
e60ffa4
clang format
grishatop1 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions src/modules/network.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,18 +1067,15 @@ void waybar::modules::Network::parseSignal(struct nlattr** bss) {
if (bss[NL80211_BSS_SIGNAL_MBM] != nullptr) {
// signalstrength in dBm from mBm
signal_strength_dbm_ = nla_get_s32(bss[NL80211_BSS_SIGNAL_MBM]) / 100;
// WiFi-hardware usually operates in the range -90 to -30dBm.

// If a signal is too strong, it can overwhelm receiving circuity that is designed
// to pick up and process a certain signal level. The following percentage is scaled to
// punish signals that are too strong (>= -45dBm) or too weak (<= -45 dBm).
const int hardwareOptimum = -45;
const int hardwareMin = -90;
const int strength =
100 -
((abs(signal_strength_dbm_ - hardwareOptimum) / double{hardwareOptimum - hardwareMin}) *
100);
signal_strength_ = std::clamp(strength, 0, 100);

// uses nmcli implementation for calculating strength
// https://github.com/NetworkManager/NetworkManager/blob/23ffa5fc6e7acbd7a96138c6c18f478f5127177d/src/libnm-platform/wifi/nm-wifi-utils-nl80211.c#L411

const int noise_floor_dbm = -90;
const int signal_max_dbm = -20;
signal_strength_dbm_ = CLAMP(signal_strength_dbm_, noise_floor_dbm, signal_max_dbm);
signal_strength_ = 100 - (70 * (((float)signal_max_dbm - (float)signal_strength_dbm_) /
((float)signal_max_dbm - (float)noise_floor_dbm)));

if (signal_strength_dbm_ >= -50) {
signal_strength_app_ = "Great Connectivity";
Expand Down
Loading