Skip to content

refactor: rm direct dp.emit() call in constructor. - #5208

Merged
Alexays merged 1 commit into
Alexays:masterfrom
Mrpaoo:ref/rm-dpemit
Jul 19, 2026
Merged

refactor: rm direct dp.emit() call in constructor.#5208
Alexays merged 1 commit into
Alexays:masterfrom
Mrpaoo:ref/rm-dpemit

Conversation

@Mrpaoo

@Mrpaoo Mrpaoo commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?
Remove the dp.emit() call in constructor, at this time, the dp isn't connect to callback, so it make no sense.

Related issues
N/A

Checklist

  • Code is formatted with clang-format
  • Builds locally (ninja -C build)
  • Man page updated for any new/changed user-facing option (man/)
  • Tested against the affected module(s)

@Mrpaoo

Mrpaoo commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author

However, dp.emit() still call before the dp.connect according to the #5200 (comment), which thread could call dp.emit() before connected. I would track this down in #5205

@Alexays
Alexays merged commit 456f78e into Alexays:master Jul 19, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants