config: add min-brightness to backlight example#5209
Open
gitmpr wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The backlight module has supported
min-brightnesssince #3637, but the shippedconfig.jsoncdoesn't set it. Without it, scrolling over the backlight widget can take the screen to full black. Adding"min-brightness": 1to the example config means anyone copying it gets safe defaults out of the box.Note: there is a related bug where a scroll step that crosses
min-brightnessisn't clamped (e.g. scrolling from 5% withscroll-step: 5andmin-brightness: 1still reaches 0%). That is fixed separately in #5210. This PR and #5210 are complementary.Related issues
Closes #2275
Checklist
clang-formatninja -C build)man/)