fix(mpris): sanitize metadata to prevent multiline UI expansion - #5225
Open
JuustKiwi wants to merge 1 commit into
Open
fix(mpris): sanitize metadata to prevent multiline UI expansion#5225JuustKiwi wants to merge 1 commit into
JuustKiwi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I introduced a local sanitizer lambda in src/modules/mpris/mpris.cpp inside the getPlayerInfo() function. Before assigning the raw D-Bus C-strings to the PlayerInfo struct, the sanitizer converts them to std::string and uses std::replace to swap any \n or \r characters with standard spaces.
Related issues
Closes #4971
Checklist
clang-formatninja -C build)man/)