[PWGCF] Add 2D pt Efficiency calculation#14604
Merged
victor-gonzalez merged 4 commits intoAliceO2Group:masterfrom Jan 23, 2026
Merged
[PWGCF] Add 2D pt Efficiency calculation#14604victor-gonzalez merged 4 commits intoAliceO2Group:masterfrom
victor-gonzalez merged 4 commits intoAliceO2Group:masterfrom
Conversation
huinaibing
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#14604
Comment on lines
+1058
to
+1072
| case MyFunctionName::funcProcessData: | ||
| this->registry.fill(HIST("hEventCount/processData"), position); | ||
| break; | ||
| case MyFunctionName::funcDetectorPidQA: | ||
| this->registry.fill(HIST("hEventCount/detectorPidQA"), position); | ||
| break; | ||
| case MyFunctionName::funcFillCorrectionGraph: | ||
| this->registry.fill(HIST("hEventCount/fillCorrectionGraph"), position); | ||
| break; | ||
| case MyFunctionName::funcProcessReco: | ||
| this->registry.fill(HIST("hEventCount/processReco"), position); | ||
| break; | ||
| case MyFunctionName::funcProcessSim: | ||
| this->registry.fill(HIST("hEventCount/processSim"), position); | ||
| break; |
Collaborator
There was a problem hiding this comment.
Why using this? It is not needed and creates the impression that actually it is
| return false; | ||
| } | ||
| registry.fill(HIST("hEventCount"), 2.5); | ||
| this->fillEventCountHelper(funcName, 2.5); |
| if (cfgOutputrunbyrun) { | ||
| // hist for NUA | ||
| registry.add("correction/hRunNumberPhiEtaVertex", "", {HistType::kTHnSparseF, {cfgaxisRun, cfgaxisPhi, cfgaxisEta, cfgaxisVertex}}); | ||
| registry.add("correction/hRunNumberPhiEtaVertex", "", {HistType::kTHnSparseD, {cfgaxisRun, cfgaxisPhi, cfgaxisEta, cfgaxisVertex}}); |
Collaborator
There was a problem hiding this comment.
Are you sure you want this leap in memory usage?
Do you actually need a double per bin?
Contributor
Author
There was a problem hiding this comment.
Thank you for your comment, Professor. I’m used to writing Python, so I instinctively added this-> when coding in C++. This is indeed unnecessary. Also, the change from thnsparsef to thnspared was made during my local testing – the order of magnitude does not appear to reach the limit of float, and I will correct these details in the next PR.
victor-gonzalez
approved these changes
Jan 23, 2026
Collaborator
victor-gonzalez
left a comment
victor-gonzalez
left a comment
There was a problem hiding this comment.
Please, have a look at my comments for future iterations
FrancescaCasillo
pushed a commit
to FrancescaCasillo/O2Physics
that referenced
this pull request
Jan 26, 2026
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
fcolamar
pushed a commit
to fcolamar/O2Physics
that referenced
this pull request
Feb 4, 2026
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
processReco&&processSim) for 2D Eff(pt, cent) calculationsetCurrentParticleWeightto apply 2D Eff