[PWGHF] add hadron dca histogram #14764
Closed
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
sejeong8
added a commit
to sejeong8/O2Physics
that referenced
this pull request
Feb 3, 2026
Please consider the following formatting changes to AliceO2Group#14764
sejeong8
added a commit
to sejeong8/O2Physics
that referenced
this pull request
Feb 3, 2026
Please consider the following formatting changes to AliceO2Group#14764
sejeong8
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
jpxrk
approved these changes
Feb 3, 2026
vkucera
requested changes
Feb 3, 2026
Collaborator
vkucera
left a comment
vkucera
left a comment
There was a problem hiding this comment.
- The scope of the PR is missing in the title. Please add the name of the file or the task.
- Most of the changes are breaking lines into multiple lines. Why?
Comment on lines
44
to
46
| enum PdgCode { kEta = 221, | ||
| kOmega = 223, | ||
| kEtaPrime = 331 }; |
Collaborator
There was a problem hiding this comment.
This was a temporary solution before adding the PDG codes in the common header. Now it should be removed and the codes should be used from o2::constants::physics::Pdg.
| Configurable<float> itsChi2perNClMax{"itsChi2perNClMax", 6., "min # of tpc chi2 per clusters"}; | ||
| Configurable<int> tpcNCrossedRowMin{"tpcNCrossedRowMin", 70, | ||
| "max of TPC n cluster crossed rows"}; | ||
| Configurable<float> tpcNClsFoundOverFindableMin{ |
Collaborator
There was a problem hiding this comment.
Declare configurables on a single line. Breaking it like this breaks the parsing by the linter.
Comment on lines
144
to
145
| {}, | ||
| OutputObjHandlingPolicy::AnalysisObject}; |
Collaborator
There was a problem hiding this comment.
Redundant. Only the name is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add hadron dca histogram