Skip to content

[OGUI-1892] Disable level buttons for shifter users on page load and after - #3438

Closed
graduta wants to merge 20 commits into
devfrom
feature/ILG/OGUI-1892-disable-level-buttons-for-shifter-users
Closed

[OGUI-1892] Disable level buttons for shifter users on page load and after#3438
graduta wants to merge 20 commits into
devfrom
feature/ILG/OGUI-1892-disable-level-buttons-for-shifter-users

Conversation

@graduta

@graduta graduta commented May 7, 2026

Copy link
Copy Markdown
Member

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected
  • FLP integration tests were ran successful

PR which:

  • if user authenticated has a role of "shifter" but not "admin":
    • the UI will disable the buttons changing the "level" of messages filtering system
    • even if the URL contains a higher level, this level will be brought back to level 1 (operations)
  • adds tests to validated newly added changes
  • adds const/enums for roles and infologger levels
  • extracts button into a reusable component and defines objects for existing filters

@graduta
graduta requested a review from isaachilly May 7, 2026 07:39
@graduta graduta self-assigned this May 7, 2026
Comment thread InfoLogger/public/logFilter/commandFilters.js Outdated
Comment thread InfoLogger/public/logFilter/commandFilters.js
Comment thread InfoLogger/public/logFilter/commandFilters.js
Comment thread InfoLogger/public/Model.js Outdated
Comment thread InfoLogger/test/public/shifter-based-actions-mocha.js
Comment thread InfoLogger/public/common/utils.js
Comment thread InfoLogger/public/Model.js

@isaachilly isaachilly left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my thoughts and comments.

@graduta
graduta requested a review from isaachilly May 20, 2026 07:15
@graduta

graduta commented May 22, 2026

Copy link
Copy Markdown
Member Author

Closing this PR for now, details in the Jira ticket

@graduta graduta closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants