Add support for ldexp intrinsic
#1263
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thanks Mitch. it looks good to me overall, but of course Nuno will have opinions about the details. can you add some test cases that involve vectors, and also some test cases that aren't corner cases? that is, a few of them (with both positive and negative values for the integer argument) that result in just regular in-range values? |
Author
|
Done. Also, I should mention this fixes #1262. |
nunoplopes
reviewed
Jan 1, 2026
| dup(Function &f, const std::string &suffix) const override; | ||
| }; | ||
|
|
||
|
|
nunoplopes
reviewed
Jan 1, 2026
| } | ||
|
|
||
| ; Currently times out | ||
| ; define float @src15(float %x) { |
Member
There was a problem hiding this comment.
you can leave timing out tests uncommented. They will not fail the test.
Member
|
The algorithm is not correct. It's actually quite hard to implement ldexp. For example, for zero underflow: x = 2.0f / rhs = -150. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributing, so please let me know if the SMT can be simplified.