fix(stats): show network-only loss in performance overlay - #126
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughChanges性能数据与呈现设置
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: 🔵 Low · up to The PR changes the performance overlay to show network-only frame loss while also broadening host-paced presentation defaults. It is mergeable with explicit owner awareness that the pinned common-c revision must be confirmed compatible with the new estimator API; no higher-severity merge-blocking issue is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (6 skipped: 6 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
be72625 to
4a81061
Compare
改了啥呀
networkFrameLossPercentpacketLoss给 ABR 和串流战报使用,才不会把杂鱼指标偷偷换口径啦mic,提交b546795)为啥要改
原覆盖层使用客户端滑动窗口统计,可能包含解码器或渲染路径的主动丢帧,无法只代表网络质量。新指标复用 common-c 的 3 秒连接状态采样,表示 FEC 后仍不可恢复的网络视频帧丢失。
验证
npm run check:scripts通过mic基线下完整 HarmonyOS Release HAP 构建成功git diff --check通过Summary by CodeRabbit
新功能
问题修复